Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60153 )
Change subject: mb/google/hatch/Kconfig: Put baseboard option before variants ......................................................................
mb/google/hatch/Kconfig: Put baseboard option before variants
Align with other mainboards and put the baseboard option before the variants ones.
Change-Id: I314239b6d5abd531ccdcbe4426b2c7956dc9ae45 Signed-off-by: Felix Singer felixsinger@posteo.net Reviewed-on: https://review.coreboot.org/c/coreboot/+/60153 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/google/hatch/Kconfig 1 file changed, 16 insertions(+), 16 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved Tim Wawrzynczak: Looks good to me, approved
diff --git a/src/mainboard/google/hatch/Kconfig b/src/mainboard/google/hatch/Kconfig index f17882e..824c1ee 100644 --- a/src/mainboard/google/hatch/Kconfig +++ b/src/mainboard/google/hatch/Kconfig @@ -1,20 +1,4 @@
-config BOARD_GOOGLE_BASEBOARD_HATCH - def_bool n - select BOARD_GOOGLE_HATCH_COMMON - select SYSTEM_TYPE_LAPTOP - -config BOARD_GOOGLE_BASEBOARD_PUFF - def_bool n - select BOARD_GOOGLE_HATCH_COMMON - select RT8168_GET_MAC_FROM_VPD - select RT8168_SET_LED_MODE - select RT8168_GEN_ACPI_POWER_RESOURCE - select ROMSTAGE_SPD_SMBUS - select SPD_READ_BY_WORD - select SOC_INTEL_CSE_LITE_SKU - select DRIVERS_INTEL_DPTF - config BOARD_GOOGLE_HATCH_COMMON def_bool n select BOARD_ROMSIZE_KB_16384 if !BOARD_ROMSIZE_KB_32768 @@ -42,6 +26,22 @@ select SOC_INTEL_COMETLAKE_1 select SOC_INTEL_COMMON_BLOCK_DTT
+config BOARD_GOOGLE_BASEBOARD_HATCH + def_bool n + select BOARD_GOOGLE_HATCH_COMMON + select SYSTEM_TYPE_LAPTOP + +config BOARD_GOOGLE_BASEBOARD_PUFF + def_bool n + select BOARD_GOOGLE_HATCH_COMMON + select RT8168_GET_MAC_FROM_VPD + select RT8168_SET_LED_MODE + select RT8168_GEN_ACPI_POWER_RESOURCE + select ROMSTAGE_SPD_SMBUS + select SPD_READ_BY_WORD + select SOC_INTEL_CSE_LITE_SKU + select DRIVERS_INTEL_DPTF + if BOARD_GOOGLE_HATCH_COMMON
config CHROMEOS