Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Felix Held.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61690 )
Change subject: soc/amd/cezanne: Add ability to dump Smart Trace Buffer in bootblock
......................................................................
Patch Set 3:
(2 comments)
File src/soc/amd/cezanne/stb.c:
https://review.coreboot.org/c/coreboot/+/61690/comment/889b840a_7a1c726b
PS3, Line 11: 0x03E30600
Is it the address where the STB resides?
https://review.coreboot.org/c/coreboot/+/61690/comment/321b61bb_e1f9b8c0
PS3, Line 30: for (i = 0; i < FIFO_SIZE; i++) {
Is it ok to stop at the STB_MARKER that we inserted instead of dumping the entire FIFO. May be it will reduce the noise.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61690
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ied3010ba0fc1d7327fe07df562f0483099d6b165
Gerrit-Change-Number: 61690
Gerrit-PatchSet: 3
Gerrit-Owner: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 08 Feb 2022 00:46:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment