Attention is currently required from: Filip Lewiński, Krystian Hebel, Maciej Pijanowski, Martin L Roth, Michał Kopeć.
Felix Singer has posted comments on this change by Filip Lewiński. ( https://review.coreboot.org/c/coreboot/+/83385?usp=email )
Change subject: payloads/external/iPXE/Makefile: Build iPXE for EFI target if requested
......................................................................
Patch Set 3:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83385/comment/9d513b86_c0a1fecd?usp... :
PS3, Line 7: Build iPXE for EFI target if requested
Suggestion:
Allow building EFI target
https://review.coreboot.org/c/coreboot/+/83385/comment/52abfe53_0c1f8642?usp... :
PS3, Line 7: /Makefile
Remove "Makefile" from the title.
File payloads/external/iPXE/Kconfig:
https://review.coreboot.org/c/coreboot/+/83385/comment/4b5a591d_6a6fb312?usp... :
PS3, Line 119: config IPXE_BUILD_EFI
Please make that a choice menu, so the difference between EFI and non-EFI is clear.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83385?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7f247a59a65aeb18a67475d4d543f519af88aeb9
Gerrit-Change-Number: 83385
Gerrit-PatchSet: 3
Gerrit-Owner: Filip Lewiński
filip.lewinski@3mdeb.com
Gerrit-Reviewer: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Reviewer: Maciej Pijanowski
maciej.pijanowski@3mdeb.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-CC: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Maciej Pijanowski
maciej.pijanowski@3mdeb.com
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Filip Lewiński
filip.lewinski@3mdeb.com
Gerrit-Attention: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Attention: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Comment-Date: Thu, 25 Jul 2024 13:36:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No