Tim Van Patten has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/74126 )
Change subject: soc/amd/mendocino: Reinterpret smu_power_and_thm_limit ......................................................................
soc/amd/mendocino: Reinterpret smu_power_and_thm_limit
The FSP will return the TDP in the format 0xX0000, where 'X' is the value we're interested in. For example: 0xF0000 (15W), 0x60000 (6W). Re-interpret the value so the caller just sees the TDP directly, without needing to re-interpret things themselves.
BUG=b:253301653 TEST=Manually verify value is correct
Change-Id: I632e702d986a4ac85605040e09c1afab2bbdc59d --- M src/soc/amd/mendocino/fsp_misc_data_hob.c 1 file changed, 22 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/74126/1
diff --git a/src/soc/amd/mendocino/fsp_misc_data_hob.c b/src/soc/amd/mendocino/fsp_misc_data_hob.c index 103f821..1c5beac 100644 --- a/src/soc/amd/mendocino/fsp_misc_data_hob.c +++ b/src/soc/amd/mendocino/fsp_misc_data_hob.c @@ -43,6 +43,11 @@ if (get_amd_misc_data_hob(&fsp_misc_data, AMD_MISC_DATA_VERSION) != CB_SUCCESS) return CB_ERR;
+ // The FSP will return the TDP in the format 0xX0000, where 'X' is the value + // we're interested in. For example: 0xF0000 (15W), 0x60000 (6W). Re-interpret + // the value so the caller just sees the TDP. + printk(BIOS_INFO, "fsp_misc_data->smu_power_and_thm_limit = %u\n", + fsp_misc_data->smu_power_and_thm_limit); *tdp = fsp_misc_data->smu_power_and_thm_limit;
return CB_SUCCESS;