Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43145 )
Change subject: build system: Rely on xcompile for HOSTCC and HOSTCXX ......................................................................
build system: Rely on xcompile for HOSTCC and HOSTCXX
It already looks for them, so let's use the result instead of blindly defaulting to gcc/g++.
Change-Id: I3e50c70a609f1903a925610928f8779c191040d8 Signed-off-by: Patrick Georgi pgeorgi@google.com --- M Makefile 1 file changed, 0 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/43145/1
diff --git a/Makefile b/Makefile index 6a96f9d..ba1e280 100644 --- a/Makefile +++ b/Makefile @@ -61,8 +61,6 @@ # Disable implicit/built-in rules to make Makefile errors fail fast. .SUFFIXES:
-HOSTCC := $(if $(shell type gcc 2>/dev/null),gcc,cc) -HOSTCXX = g++ HOSTCFLAGS := -g HOSTCXXFLAGS := -g
Hello Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/43145
to look at the new patch set (#2).
Change subject: build system: Rely on xcompile for HOSTCC and HOSTCXX ......................................................................
build system: Rely on xcompile for HOSTCC and HOSTCXX
It already looks for them, so let's use the result instead of blindly defaulting to gcc/g++.
Change-Id: I3e50c70a609f1903a925610928f8779c191040d8 Signed-off-by: Patrick Georgi pgeorgi@google.com --- M Makefile 1 file changed, 0 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/43145/2
Hello build bot (Jenkins), Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/43145
to look at the new patch set (#3).
Change subject: build system: Rely on xcompile for HOSTCC and HOSTCXX ......................................................................
build system: Rely on xcompile for HOSTCC and HOSTCXX
It already looks for them, so let's use the result instead of blindly defaulting to gcc/g++, except when not building an image (but run kconfig or tests) because we don't use xcompile in those cases.
Change-Id: I3e50c70a609f1903a925610928f8779c191040d8 Signed-off-by: Patrick Georgi pgeorgi@google.com --- M Makefile 1 file changed, 5 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/43145/3
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43145 )
Change subject: build system: Rely on xcompile for HOSTCC and HOSTCXX ......................................................................
Patch Set 3: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43145 )
Change subject: build system: Rely on xcompile for HOSTCC and HOSTCXX ......................................................................
build system: Rely on xcompile for HOSTCC and HOSTCXX
It already looks for them, so let's use the result instead of blindly defaulting to gcc/g++, except when not building an image (but run kconfig or tests) because we don't use xcompile in those cases.
Change-Id: I3e50c70a609f1903a925610928f8779c191040d8 Signed-off-by: Patrick Georgi pgeorgi@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/43145 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Nico Huber nico.h@gmx.de --- M Makefile 1 file changed, 5 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved
diff --git a/Makefile b/Makefile index 6a96f9d..2705c66 100644 --- a/Makefile +++ b/Makefile @@ -61,8 +61,6 @@ # Disable implicit/built-in rules to make Makefile errors fail fast. .SUFFIXES:
-HOSTCC := $(if $(shell type gcc 2>/dev/null),gcc,cc) -HOSTCXX = g++ HOSTCFLAGS := -g HOSTCXXFLAGS := -g
@@ -128,6 +126,11 @@ rm -f $@.tmp
ifeq ($(NOCOMPILE),1) +# We also don't use .xcompile in the no-compile situations, so +# provide some reasonable defaults. +HOSTCC ?= $(if $(shell type gcc 2>/dev/null),gcc,cc) +HOSTCXX ?= g++ + include $(TOPLEVEL)/Makefile.inc include $(TOPLEVEL)/payloads/Makefile.inc include $(TOPLEVEL)/util/testing/Makefile.inc