Attention is currently required from: Hung-Te Lin, Rex-BC Chen, Yu-Ping Wu.
Jianjun Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62791 )
Change subject: soc/mediatek: Add chip config for setting PCIe controller data
......................................................................
Patch Set 2:
(1 comment)
File src/soc/mediatek/common/pcie.c:
https://review.coreboot.org/c/coreboot/+/62791/comment/cde6b6f1_ff6be185
PS2, Line 109: pcie_ctrl
This global variable makes me wonder if putting the 'base' in the devicetree is the right decision. […]
I think it's ok to use PCIE_REG_BASE.
Another way to get the base address is by "pcidev_path_on_root(pci_devfn devfn)", we can get the device first, and get the config data from config_of(dev), but it will take more time than just define it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62791
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icff83f2a9f76862065987a74cfcc7e511be80a20
Gerrit-Change-Number: 62791
Gerrit-PatchSet: 2
Gerrit-Owner: Jianjun Wang
jianjun.wang@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Tue, 15 Mar 2022 04:24:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Gerrit-MessageType: comment