[L] Change in coreboot[main]: mb/asrock: Add Z87E-ITX (Haswell)

[Nicholas Chin (Code Review)]

Attention is currently required from: Angel Pons, Máté Kukri.

Nicholas Chin has posted comments on this change by Nicholas Chin. ( https://review.coreboot.org/c/coreboot/+/81022?usp=email )

Change subject: mb/asrock: Add Z87E-ITX (Haswell)
......................................................................

Patch Set 3:

(8 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/81022/comment/25230d2b_06564cfc?usp... :
PS2, Line 14: socketted
> nit: socketed (one t)

Done

File src/mainboard/asrock/z87e-itx/data.vbt:

PS2:
> How was this file obtained? Dump under Linux?

Updated the commit message.

File src/mainboard/asrock/z87e-itx/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/81022/comment/06d547a6_b672576b?usp... :
PS2, Line 4: 	register "ec_present" = "false"
> Any zero/false options can be omitted

Done

https://review.coreboot.org/c/coreboot/+/81022/comment/0c2eb8f5_89f22fb6?usp... :
PS2, Line 10: register "panel_cfg" = "{
            : 		.up_delay_ms		=   0,
            : 		.down_delay_ms		=   0,
            : 		.cycle_delay_ms		= 500,
            : 		.backlight_on_delay_ms	=   0,
            : 		.backlight_off_delay_ms	=   0,
            : 		.backlight_pwm_hz	=   0,
            : 	}"
> There's no panel on this board

Done

File src/mainboard/asrock/z87e-itx/gma-mainboard.ads:

https://review.coreboot.org/c/coreboot/+/81022/comment/3ad70cac_ba581b36?usp... :
PS2, Line 20: LVDS,
            :       eDP
> Replace these two with `others => Disabled`

Done

File src/mainboard/asrock/z87e-itx/romstage.c:

https://review.coreboot.org/c/coreboot/+/81022/comment/f13c33cf_87a853ac?usp... :
PS2, Line 12: /* FIXME: called after romstage_common, remove it if not used */
> I guess try removing this?

Done

https://review.coreboot.org/c/coreboot/+/81022/comment/192d1196_cd87d7a1?usp... :
PS2, Line 19: 	/* FIXME: check this */
> It's most likely 0x50 and 0x52, the first slot of each channel.

Done

https://review.coreboot.org/c/coreboot/+/81022/comment/a0627ab0_7331d30e?usp... :
PS2, Line 27: 	/* FIXME: Length and Location are computed from IOBP values, may be inaccurate */
> If all USB ports work, remove the FIXME?

Done