Attention is currently required from: Paul Menzel, Tim Wawrzynczak, Sumeet R Pawnikar.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62789 )
Change subject: ec/google/chromeec: add fan speed rpm control
......................................................................
Patch Set 3:
(1 comment)
File src/ec/google/chromeec/acpi/ec.asl:
https://review.coreboot.org/c/coreboot/+/62789/comment/f21e24ab_3a8c5733
PS3, Line 85: CFSP, 16, // Set Fan speed in rpm
I think we need identify EC offset. This is conflict to https://review.coreboot.org/c/coreboot/+/62946/9/src/ec/google/chromeec/acpi...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62789
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibb1646b1fb1659fd853ece97d97bb9dee2a3f57e
Gerrit-Change-Number: 62789
Gerrit-PatchSet: 3
Gerrit-Owner: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Comment-Date: Fri, 15 Apr 2022 01:17:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment