build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34728 )
Change subject: soc/intel/common: Implement MAINBOARD_POWER_STATE_PREVIOUS
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34728/4/src/soc/intel/common/block/...
File src/soc/intel/common/block/include/intelblocks/pmclib.h:
https://review.coreboot.org/c/coreboot/+/34728/4/src/soc/intel/common/block/...
PS4, Line 227: void pmc_set_power_failure_state(pci_devfn_t, bool target_on);
function definition argument 'pci_devfn_t' should also have an identifier name
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34728
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I22bd71e4f3b67309c1aa0cb6faeb5959521bf656
Gerrit-Change-Number: 34728
Gerrit-PatchSet: 4
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Wed, 07 Aug 2019 22:41:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment