[M] Change in coreboot[master]: util/amdfwtool/amdfwread: Update relative_offset function
Attention is currently required from: Robert Zieba, Raul Rangel, Jon Murphy, Rob Barnes, Felix Held.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66572 )
Change subject: util/amdfwtool/amdfwread: Update relative_offset function ......................................................................
Patch Set 14:
(2 comments)
File util/amdfwtool/amdfwread.c:
https://review.coreboot.org/c/coreboot/+/66572/comment/93ad7c99_dfd62108 PS13, Line 38: /* Intentional fall-through */
Prefer 'fallthrough;' over fallthrough comment […]
I have to remove the check for AMD_ADDR_PHYSICAL since that check breaks the amdfwread for Guybrush & variants.
Unfortunately in guybrush/dewatt, all the addresses are marked as Physical even though they are all relative to BIOS. Hence the check is causing the failure. We have to remove it until we fix the amdfwtool.
https://review.coreboot.org/c/coreboot/+/66572/comment/fa39eb72_d1fbf8a5 PS13, Line 40: & FILE_REL_MASK
Instead of silently dropping the top bits, can we check `if addr < FILE_REL_MASK then return addr el […]
Done
-
Karthik Ramasubramanian (Code Review)