build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30123 )
Change subject: cpuid: Move cpuid(1) function into arch/x86/cpu_common code
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/30123/2/src/northbridge/intel/haswell/report...
File src/northbridge/intel/haswell/report_platform.c:
https://review.coreboot.org/#/c/30123/2/src/northbridge/intel/haswell/report...
PS2, Line 56: printk(BIOS_DEBUG, "CPU id(%x) ucode:%08x %s\n", cpu_id, microcode_ver.hi, cpu_name);
line over 80 characters
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30123
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib96a7c79dadb1feff0b8d58aa408b355fbb3bc50
Gerrit-Change-Number: 30123
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 10 Dec 2018 11:33:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment