Jingle Hsu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43005 )
Change subject: mb/ocp/deltalake: Send OEM IPMI command for CMOS clear on RTC failure
......................................................................
Patch Set 12:
(2 comments)
https://review.coreboot.org/c/coreboot/+/43005/12/src/mainboard/ocp/deltalak...
File src/mainboard/ocp/deltalake/ipmi.c:
https://review.coreboot.org/c/coreboot/+/43005/12/src/mainboard/ocp/deltalak...
PS12, Line 118:
Remove this line.
Done
https://review.coreboot.org/c/coreboot/+/43005/12/src/mainboard/ocp/deltalak...
File src/mainboard/ocp/deltalake/romstage.c:
https://review.coreboot.org/c/coreboot/+/43005/12/src/mainboard/ocp/deltalak...
PS12, Line 103: BIOS_DEBUG
When res is not CB_SUCCESS need to use higher verbose BIOS_ERR to print it.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43005
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I27428c02e99040754e15e07782ec1ad8524def2f
Gerrit-Change-Number: 43005
Gerrit-PatchSet: 12
Gerrit-Owner: Jingle Hsu
jingle_hsu@wiwynn.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Morgan Jang
Morgan_Jang@wiwynn.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Rocky Phagura
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 10 Jul 2020 09:32:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-MessageType: comment