Attention is currently required from: Zheng Bao.
Hello Zheng Bao,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/68884
to review the following change.
Change subject: stoneyridge: Set the SPI read speed as 66MHz ......................................................................
stoneyridge: Set the SPI read speed as 66MHz
The SPI read mode for Family 15h in EFS header has been affected by these two patches. It causes the ChromeBook booting unstable. The old settings are all FF, which means nothing. So we can not just change it back. We just change the speed to "Normal", which I assume has the same effect with old settings. Tested on Grunt.
https://review.coreboot.org/c/coreboot/+/58555 https://review.coreboot.org/c/coreboot/+/58871
BUG=b:247025109 TEST=Grunt
Change-Id: Ia6083cfa515abeb2e981ff0ef825970c9311466b Signed-off-by: Zheng Bao fishbaozi@gmail.com --- M src/mainboard/amd/gardenia/Kconfig M src/mainboard/amd/pademelon/Kconfig M src/mainboard/google/kahlee/Kconfig 3 files changed, 25 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/68884/1
diff --git a/src/mainboard/amd/gardenia/Kconfig b/src/mainboard/amd/gardenia/Kconfig index 2925fd6..eed4f07 100644 --- a/src/mainboard/amd/gardenia/Kconfig +++ b/src/mainboard/amd/gardenia/Kconfig @@ -35,7 +35,7 @@
if !EM100 config EFS_SPI_READ_MODE - default 4 # Dual IO (1-2-2) + default 0 # Normal
config EFS_SPI_SPEED default 0 # 66MHz diff --git a/src/mainboard/amd/pademelon/Kconfig b/src/mainboard/amd/pademelon/Kconfig index 9890d7f..593135f 100644 --- a/src/mainboard/amd/pademelon/Kconfig +++ b/src/mainboard/amd/pademelon/Kconfig @@ -65,7 +65,7 @@
if !EM100 config EFS_SPI_READ_MODE - default 4 # Dual IO (1-2-2) + default 0 # Normal
config EFS_SPI_SPEED default 0 # 66MHz diff --git a/src/mainboard/google/kahlee/Kconfig b/src/mainboard/google/kahlee/Kconfig index 8c8486e..cdd6d54 100644 --- a/src/mainboard/google/kahlee/Kconfig +++ b/src/mainboard/google/kahlee/Kconfig @@ -129,7 +129,7 @@
if !EM100 # EM100 defaults in soc/amd/common/blocks/spi/Kconfig config EFS_SPI_READ_MODE - default 4 # Dual IO (1-2-2) + default 0 # Normal
config EFS_SPI_SPEED default 0 # 66MHz