Wim Vervoorn has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39920 )
Change subject: soc/intel/common/block/cse: Add check for CSE enabled ......................................................................
soc/intel/common/block/cse: Add check for CSE enabled
Exit print_me_fw_version if CSE is disabled.
BUG=N/A TEST=tested on facebook monolith
Change-Id: Ie3f1c2a5a7f96371a0da872efc3308850c382ba7 Signed-off-by: Wim Vervoorn wvervoorn@eltan.com --- M src/soc/intel/common/block/cse/cse.c 1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/39920/1
diff --git a/src/soc/intel/common/block/cse/cse.c b/src/soc/intel/common/block/cse/cse.c index b93594a..86ed038 100644 --- a/src/soc/intel/common/block/cse/cse.c +++ b/src/soc/intel/common/block/cse/cse.c @@ -827,6 +827,10 @@ if (!CONFIG(CONSOLE_SERIAL)) return;
+ /* Ignore if CSE is disabled */ + if (!is_cse_enabled()) + return; + /* * Ignore if ME Firmware SKU type is custom since * print_boot_partition_info() logs RO(BP1) and RW(BP2) versions.
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39920 )
Change subject: soc/intel/common/block/cse: Add check for CSE enabled ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/39920 )
Change subject: soc/intel/common/block/cse: Add check for CSE enabled ......................................................................
soc/intel/common/block/cse: Add check for CSE enabled
Exit print_me_fw_version if CSE is disabled.
BUG=N/A TEST=tested on facebook monolith
Change-Id: Ie3f1c2a5a7f96371a0da872efc3308850c382ba7 Signed-off-by: Wim Vervoorn wvervoorn@eltan.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/39920 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Frans Hendriks fhendriks@eltan.com --- M src/soc/intel/common/block/cse/cse.c 1 file changed, 4 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Frans Hendriks: Looks good to me, approved
diff --git a/src/soc/intel/common/block/cse/cse.c b/src/soc/intel/common/block/cse/cse.c index b93594a..86ed038 100644 --- a/src/soc/intel/common/block/cse/cse.c +++ b/src/soc/intel/common/block/cse/cse.c @@ -827,6 +827,10 @@ if (!CONFIG(CONSOLE_SERIAL)) return;
+ /* Ignore if CSE is disabled */ + if (!is_cse_enabled()) + return; + /* * Ignore if ME Firmware SKU type is custom since * print_boot_partition_info() logs RO(BP1) and RW(BP2) versions.
-
Frans Hendriks (Code Review) -
Patrick Georgi (Code Review)
-
Wim Vervoorn (Code Review)