Change in coreboot[master]: soc/intel/xeon_sp/cpx: add ACPI name for CSTACK

[Jonathan Zhang (Code Review)]

Jonathan Zhang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45591 )

Change subject: soc/intel/xeon_sp/cpx: add ACPI name for CSTACK
......................................................................

soc/intel/xeon_sp/cpx: add ACPI name for CSTACK

Add ACPI name for CSTACK. The name is PC00 to match with ACPI table
generated.

The PCIe domain has multiple PCIe stacks. devicetree.cb at the moment
does not support multiple PCIe stacks, eg. IIO stacks. For now, assign
the name to PCIe domain. In future, the name needs to be assigned to
CSTACK.

Signed-off-by: Jonathan Zhang 
Change-Id: I24a6f29734452426218419cdcf66702edde96f46
---
M src/soc/intel/xeon_sp/cpx/chip.c
1 file changed, 12 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/45591/1

diff --git a/src/soc/intel/xeon_sp/cpx/chip.c b/src/soc/intel/xeon_sp/cpx/chip.c
index 2c445f9..5ee7f6c 100644
--- a/src/soc/intel/xeon_sp/cpx/chip.c
+++ b/src/soc/intel/xeon_sp/cpx/chip.c
@@ -492,11 +492,23 @@
    /* not implemented yet */
 }

+#if CONFIG(HAVE_ACPI_TABLES)
+static const char *soc_acpi_name(const struct device *dev)
+{
+	if (dev->path.type == DEVICE_PATH_DOMAIN)
+		return "PC00";
+	return NULL;
+}
+#endif
+
 static struct device_operations pci_domain_ops = {
    .read_resources = &pci_domain_read_resources,
    .set_resources = &xeonsp_cpx_pci_domain_set_resources,
    .scan_bus = &xeonsp_cpx_pci_domain_scan_bus,
+#if CONFIG(HAVE_ACPI_TABLES)
    .write_acpi_tables  = &northbridge_write_acpi_tables,
+	.acpi_name        = soc_acpi_name
+#endif
 };

static struct device_operations cpu_bus_ops = {

[Marc Jones (Code Review)]

Marc Jones has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45591 )

Change subject: soc/intel/xeon_sp/cpx: add ACPI name for CSTACK
......................................................................

Patch Set 1: Code-Review+2

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45591 )

Change subject: soc/intel/xeon_sp/cpx: add ACPI name for CSTACK
......................................................................

Patch Set 3: Code-Review+1

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45591 )

Change subject: soc/intel/xeon_sp/cpx: add ACPI name for CSTACK
......................................................................

soc/intel/xeon_sp/cpx: add ACPI name for CSTACK

Add ACPI name for CSTACK. The name is PC00 to match with ACPI table
generated.

The PCIe domain has multiple PCIe stacks. devicetree.cb at the moment
does not support multiple PCIe stacks, eg. IIO stacks. For now, assign
the name to PCIe domain. In future, the name needs to be assigned to
CSTACK.

Signed-off-by: Jonathan Zhang 
Change-Id: I24a6f29734452426218419cdcf66702edde96f46
Reviewed-on: https://review.coreboot.org/c/coreboot/+/45591
Tested-by: build bot (Jenkins) 
Reviewed-by: Angel Pons 
Reviewed-by: Marc Jones 
---
M src/soc/intel/xeon_sp/cpx/chip.c
1 file changed, 12 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Marc Jones: Looks good to me, approved
  Angel Pons: Looks good to me, but someone else must approve

diff --git a/src/soc/intel/xeon_sp/cpx/chip.c b/src/soc/intel/xeon_sp/cpx/chip.c
index 2c445f9..5ee7f6c 100644
--- a/src/soc/intel/xeon_sp/cpx/chip.c
+++ b/src/soc/intel/xeon_sp/cpx/chip.c
@@ -492,11 +492,23 @@
    /* not implemented yet */
 }

+#if CONFIG(HAVE_ACPI_TABLES)
+static const char *soc_acpi_name(const struct device *dev)
+{
+	if (dev->path.type == DEVICE_PATH_DOMAIN)
+		return "PC00";
+	return NULL;
+}
+#endif
+
 static struct device_operations pci_domain_ops = {
    .read_resources = &pci_domain_read_resources,
    .set_resources = &xeonsp_cpx_pci_domain_set_resources,
    .scan_bus = &xeonsp_cpx_pci_domain_scan_bus,
+#if CONFIG(HAVE_ACPI_TABLES)
    .write_acpi_tables  = &northbridge_write_acpi_tables,
+	.acpi_name        = soc_acpi_name
+#endif
 };

static struct device_operations cpu_bus_ops = {