Attention is currently required from: Nico Huber.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80090?usp=email )
Change subject: device/device_util: Add method to retrieve the domain
......................................................................
Patch Set 1:
(1 comment)
File src/device/device_util.c:
https://review.coreboot.org/c/coreboot/+/80090/comment/4cc0f16e_3056006f :
PS1, Line 267: while (dev->bus) {
The root device is identified by `dev == dev->bus->dev`. So the cannonical […]
That's good to know. Why not check for `dev->path.type == DEVICE_PATH_ROOT`?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80090?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I0068b82e139fe7a35e6b1b91b7d386b750c80748
Gerrit-Change-Number: 80090
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Shuo Liu
shuo.liu@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Mon, 22 Jan 2024 07:23:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment