Change in coreboot[master]: mainboard/amd/bettong: Fix typo

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

HAOUAS Elyes (Code Review)

5 Dec 2019 5 Dec '19

4:11 p.m.

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37527 )

Change subject: mainboard/amd/bettong: Fix typo ......................................................................

mainboard/amd/bettong: Fix typo

Change-Id: Id305dbe56a93740abc49d85d11402d1b63989dad Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/amd/bettong/BiosCallOuts.c M src/mainboard/amd/bettong/README 2 files changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/37527/1

diff --git a/src/mainboard/amd/bettong/BiosCallOuts.c b/src/mainboard/amd/bettong/BiosCallOuts.c index a6f424e..22a8403 100644 --- a/src/mainboard/amd/bettong/BiosCallOuts.c +++ b/src/mainboard/amd/bettong/BiosCallOuts.c @@ -100,7 +100,7 @@ FchParams_env->Usb.Xhci0Enable = FALSE;

FchParams_env->Usb.Xhci1Enable = FALSE; - FchParams_env->Usb.USB30PortInit = 8; /* 8: If USB3 port is unremoveable. */ + FchParams_env->Usb.USB30PortInit = 8; /* 8: If USB3 port is irremovable. */

/* sata configuration */ /* SD configuration */ diff --git a/src/mainboard/amd/bettong/README b/src/mainboard/amd/bettong/README index d834af4..631cf0f 100644 --- a/src/mainboard/amd/bettong/README +++ b/src/mainboard/amd/bettong/README @@ -21,5 +21,5 @@ 10. Fix the PCIe lane map. 11. Lower the TOM to give more MMIO space. 12. Add USB device. -13. Set the USB3 port as unremoveable. +13. Set the USB3 port as irremovable. 14. Update AGESA to CarrizoPI 1.1.0.1.

Attachments:

attachment.htm (text/html — 3.1 KB)

Show replies by date

Kyösti Mälkki (Code Review)

5 Dec 5 Dec

4:20 p.m.

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37527 )

Change subject: mainboard/amd/bettong: Fix typo ......................................................................

Patch Set 1:

I have to say I have never heard irremovable before. Maybe this is just US/UK English thing.

Michał Żygowski (Code Review)

4:49 p.m.

Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37527 )

Change subject: mainboard/amd/bettong: Fix typo ......................................................................

Patch Set 1:

...

Patch Set 1:

I have to say I have never heard irremovable before. Maybe this is just US/UK English thing.

https://wikidiff.com/unremovable/irremovable

-- To view, visit https://review.coreboot.org/c/coreboot/+/37527 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id305dbe56a93740abc49d85d11402d1b63989dad Gerrit-Change-Number: 37527 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-CC: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-Comment-Date: Thu, 05 Dec 2019 16:49:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Paul Menzel (Code Review)

9 Dec 9 Dec

4:53 p.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37527 )

Change subject: mainboard/amd/bettong: Fix typo ......................................................................

Patch Set 1:

(2 comments)

https://review.coreboot.org/c/coreboot/+/37527/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/37527/1//COMMIT_MSG@7 PS1, Line 7: mainboard mb

https://review.coreboot.org/c/coreboot/+/37527/1//COMMIT_MSG@7 PS1, Line 7: Fix typo Use *irremovable* over *unremovable*

-- To view, visit https://review.coreboot.org/c/coreboot/+/37527 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id305dbe56a93740abc49d85d11402d1b63989dad Gerrit-Change-Number: 37527 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-CC: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 09 Dec 2019 16:53:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

5:23 p.m.

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37527 )

Change subject: mainboard/amd/bettong: Fix typo ......................................................................

Patch Set 1:

(2 comments)

https://review.coreboot.org/c/coreboot/+/37527/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/37527/1//COMMIT_MSG@7 PS1, Line 7: Fix typo

...

Use *irremovable* over *unremovable*

Thank you

https://review.coreboot.org/c/coreboot/+/37527/1//COMMIT_MSG@7 PS1, Line 7: mainboard

...

mb

Thx

-- To view, visit https://review.coreboot.org/c/coreboot/+/37527 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id305dbe56a93740abc49d85d11402d1b63989dad Gerrit-Change-Number: 37527 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-CC: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 09 Dec 2019 17:23:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

5:23 p.m.

New subject: Change in coreboot[master]: mb/amd/bettong: Use 'irremovable' over 'unremovable'

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/37527

to look at the new patch set (#2).

Change subject: mb/amd/bettong: Use 'irremovable' over 'unremovable' ......................................................................

mb/amd/bettong: Use 'irremovable' over 'unremovable'

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/37527/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/37527 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id305dbe56a93740abc49d85d11402d1b63989dad Gerrit-Change-Number: 37527 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-CC: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

HAOUAS Elyes (Code Review)

7 Jan 7 Jan

5:09 p.m.

New subject: Change in coreboot[master]: mb/amd/bettong: Fix typo

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/37527

to look at the new patch set (#3).

Change subject: mb/amd/bettong: Fix typo ......................................................................

mb/amd/bettong: Fix typo

Use 'irremovable' over 'unremovable'

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/37527/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/37527 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id305dbe56a93740abc49d85d11402d1b63989dad Gerrit-Change-Number: 37527 Gerrit-PatchSet: 3 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-CC: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Paul Menzel (Code Review)

8 Jan 8 Jan

12:58 p.m.

New subject: Change in coreboot[master]: mb/amd/bettong: Fix typo

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37527 )

Change subject: mb/amd/bettong: Fix typo ......................................................................

Patch Set 5: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/37527 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id305dbe56a93740abc49d85d11402d1b63989dad Gerrit-Change-Number: 37527 Gerrit-PatchSet: 5 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-CC: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-Comment-Date: Wed, 08 Jan 2020 12:58:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

18 Jan 18 Jan

10:56 a.m.

New subject: Change in coreboot[master]: mb/amd/bettong: Fix typo

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37527 )

Change subject: mb/amd/bettong: Fix typo ......................................................................

Patch Set 5: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/37527 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id305dbe56a93740abc49d85d11402d1b63989dad Gerrit-Change-Number: 37527 Gerrit-PatchSet: 5 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-CC: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-Comment-Date: Sat, 18 Jan 2020 10:56:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

10:56 a.m.

New subject: Change in coreboot[master]: mb/amd/bettong: Fix typo

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37527 )

Change subject: mb/amd/bettong: Fix typo ......................................................................

mb/amd/bettong: Fix typo

Use 'irremovable' over 'unremovable'

Change-Id: Id305dbe56a93740abc49d85d11402d1b63989dad Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/37527 Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Patrick Georgi pgeorgi@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/amd/bettong/BiosCallOuts.c M src/mainboard/amd/bettong/README 2 files changed, 2 insertions(+), 2 deletions(-)

Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved Paul Menzel: Looks good to me, but someone else must approve

FchParams_env->Usb.Xhci1Enable = FALSE; - FchParams_env->Usb.USB30PortInit = 8; /* 8: If USB3 port is unremoveable. */ + FchParams_env->Usb.USB30PortInit = 8; /* 8: If USB3 port is irremovable. */

-- To view, visit https://review.coreboot.org/c/coreboot/+/37527 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id305dbe56a93740abc49d85d11402d1b63989dad Gerrit-Change-Number: 37527 Gerrit-PatchSet: 6 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-CC: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-MessageType: merged

1712

days inactive

1756

days old

coreboot-gerrit@coreboot.org

9 comments

5 participants

tags (0)

participants (5)

HAOUAS Elyes (Code Review)
Kyösti Mälkki (Code Review)
Michał Żygowski (Code Review)
Patrick Georgi (Code Review)
Paul Menzel (Code Review)