Attention is currently required from: Arthur Heymans, Christian Walter, Johnny Lin, Paul Menzel, TangYiwei, Tim Chu, Ziang Wang.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75738?usp=email )
Change subject: soc/intel/xeon_sp: Fix HEST table length
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
Patchset:
PS1:
I'm sorry but what is 'ubsan'?
Sorry, that's the 'Undefined Behavior Sanitizer'. It's something you can compile
into coreboot (should be in Kconfig somewhere) and it would tell you if the code
does something undefined.
In this case, I guess the void-pointer arithmetic would count as undefined. But
that's not to worry about because we know what GCC does with it. The code could
probably be written without the void pointers, maybe even without the variables.
But that's out of scope of this change.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75738?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6ff1e8e24612b7356772d582ff9a7e53863419db
Gerrit-Change-Number: 75738
Gerrit-PatchSet: 2
Gerrit-Owner: Ziang Wang
ziang.wang@intel.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: TangYiwei
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jeff Li
lijinfeng01@inspur.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Ziang Wang
ziang.wang@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: TangYiwei
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Comment-Date: Mon, 12 Jun 2023 08:49:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Ziang Wang
ziang.wang@intel.com
Gerrit-MessageType: comment