Attention is currently required from: Krystian Hebel, Maciej Pijanowski, Michał Żygowski.
Michał Kopeć has posted comments on this change by Michał Kopeć. ( https://review.coreboot.org/c/coreboot/+/82673?usp=email )
Change subject: mb/novacustom: add V5x0TU board (Meteor Lake)
......................................................................
Patch Set 12:
(2 comments)
File src/mainboard/novacustom/mtl-h/Kconfig:
https://review.coreboot.org/c/coreboot/+/82673/comment/8d588c86_2a1fae6f?usp... :
PS12, Line 69: 512
1024 for DDR5
Done
File src/mainboard/novacustom/mtl-h/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/82673/comment/5c7ac3e3_685a710d?usp... :
PS12, Line 61: register "device_count" = "3"
Why 3?
Should be 6, unused outputs should be counted too. Thanks for catching it
--
To view, visit
https://review.coreboot.org/c/coreboot/+/82673?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I82c73ddb1e76a9baf9b97e13124aa249ae1c2771
Gerrit-Change-Number: 82673
Gerrit-PatchSet: 12
Gerrit-Owner: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Reviewer: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Reviewer: Maciej Pijanowski
maciej.pijanowski@3mdeb.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Tim Crawford
tcrawford@system76.com
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Maciej Pijanowski
maciej.pijanowski@3mdeb.com
Gerrit-Attention: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Comment-Date: Mon, 08 Jul 2024 14:08:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Krystian Hebel
krystian.hebel@3mdeb.com