Attention is currently required from: Hung-Te Lin, Jarried Lin.
Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85613?usp=email )
Change subject: soc/mediatek/mt8196: Add pwrsel driver ......................................................................
Patch Set 1:
(4 comments)
File src/mainboard/google/rauru/romstage.c:
PS1: Move to a separate patch.
File src/soc/mediatek/mt8196/Makefile.mk:
https://review.coreboot.org/c/coreboot/+/85613/comment/243d49a4_8efe91d5?usp... : PS1, Line 33: romstage-y += mtk_pwrsel.c Move to line 36
File src/soc/mediatek/mt8196/mtk_pwrsel.c:
https://review.coreboot.org/c/coreboot/+/85613/comment/e683c4a1_cefffa16?usp... : PS1, Line 22: printk(BIOS_INFO, "PWR_SEL = %#x\n", : read32p(MCUSYS_BASE + OFFSET_PWRSEL)); one line ?
https://review.coreboot.org/c/coreboot/+/85613/comment/34345bb0_13e275e1?usp... : PS1, Line 24: printk(BIOS_INFO, "PWRSEL_CONFIG = %#x\n", : read32p(MFG_VCORE_AO_RPC_PWRSEL_CONFIG)); ditto