Attention is currently required from: Angel Pons, Benjamin Doron, David Milosevic, Julius Werner, Marvin Drees, Paul Menzel.
Maximilian Brune has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79106?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: arch/arm64: Extend cache helper functions
......................................................................
Patch Set 12:
(2 comments)
File src/arch/arm64/armv8/cache.c:
https://review.coreboot.org/c/coreboot/+/79106/comment/fec66363_1628e8f6 :
PS12, Line 61: ccsidr_el1 = raw_read_ccsidr_el1();
why remove it. Much more obvious that the same register is used to get all information if you use a variable.
File src/arch/arm64/include/armv8/arch/cache.h:
https://review.coreboot.org/c/coreboot/+/79106/comment/92e2b2be_e5b20f13 :
PS12, Line 36: uint64_t associativity; // associativity of cache
I could have seen that reading the variable name. Either explain properly or not at all in the comment
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79106?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If6fe731dc67ffeaff9344d2bd2627f45185c27de
Gerrit-Change-Number: 79106
Gerrit-PatchSet: 12
Gerrit-Owner: David Milosevic
David.Milosevic@9elements.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Marvin Drees
marvin.drees@9elements.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-CC: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Marvin Drees
marvin.drees@9elements.com
Gerrit-Attention: David Milosevic
David.Milosevic@9elements.com
Gerrit-Comment-Date: Tue, 23 Apr 2024 15:04:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment