Attention is currently required from: Alexander Couzens, Angel Pons, Felix Singer, Michał Kopeć, Paul Menzel.
Maciej Pijanowski has posted comments on this change by Maciej Pijanowski. ( https://review.coreboot.org/c/coreboot/+/80609?usp=email )
Change subject: mb/lenovo: Add ThinkCentre M920q (Coffee Lake) ......................................................................
Patch Set 12:
(8 comments)
Patchset:
PS12: Marked the obvious documentation threads as Resolved.
File Documentation/mainboard/lenovo/m920q.md:
https://review.coreboot.org/c/coreboot/+/80609/comment/7cbc41c9_fedf3171?usp... : PS10, Line 1: # Dell OptiPlex 9010
Sorry, working late sometimes does this kind of stuff. Fixed.
Done
https://review.coreboot.org/c/coreboot/+/80609/comment/99430fa2_a1545a95?usp... : PS10, Line 9: 8nd Gen or 9rd Gen
Oof, copy-pasta error? ("2***nd*** Gen or 3***rd*** Gen) […]
Done
https://review.coreboot.org/c/coreboot/+/80609/comment/bcaef8aa_54790cd2?usp... : PS10, Line 11: DIMM
Done
https://review.coreboot.org/c/coreboot/+/80609/comment/c12614ef_4ee78fd8?usp... : PS10, Line 45: yes?
I feel this could confuse people into believing that installing coreboot via the internal programmer […]
Done
https://review.coreboot.org/c/coreboot/+/80609/comment/8f40d7ea_ca165351?usp... : PS10, Line 53: flashrom -p internal -w coreboot.rom --ifd -i bios
I thought one needs `--noverify-all` too?
Done
https://review.coreboot.org/c/coreboot/+/80609/comment/0f7142c9_6412e3fa?usp... : PS10, Line 55: will
Huh? Will... […]
Done
https://review.coreboot.org/c/coreboot/+/80609/comment/0e8c6ad7_9bca6a11?usp... : PS10, Line 71: BIOS1 and BIOS1
I hope they're not marked the same 😄 […]
Done