Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/49834 )
Change subject: acpi/acpigen.c: Remove unused and incorrect functions ......................................................................
acpi/acpigen.c: Remove unused and incorrect functions
acpigen_write_name_zero() and acpigen_write_name_one() are not implemented correctly, and are not used anywhere. Drop them in favor of the more flexible acpigen_write_name_integer() function.
Signed-off-by: Jakub Czapiga jacz@semihalf.com Change-Id: I116fd41624a8e8b536d18d747f21d3131b734dfc Reviewed-on: https://review.coreboot.org/c/coreboot/+/49834 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Duncan Laurie dlaurie@chromium.org Reviewed-by: Lance Zhao Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/acpi/acpigen.c M src/include/acpi/acpigen.h 2 files changed, 0 insertions(+), 14 deletions(-)
Approvals: build bot (Jenkins): Verified Duncan Laurie: Looks good to me, approved Lance Zhao: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/src/acpi/acpigen.c b/src/acpi/acpigen.c index 9a5543d..5cc6a4e 100644 --- a/src/acpi/acpigen.c +++ b/src/acpi/acpigen.c @@ -151,18 +151,6 @@ acpigen_write_qword(data); }
-void acpigen_write_name_zero(const char *name) -{ - acpigen_write_name(name); - acpigen_write_one(); -} - -void acpigen_write_name_one(const char *name) -{ - acpigen_write_name(name); - acpigen_write_zero(); -} - void acpigen_write_name_byte(const char *name, uint8_t val) { acpigen_write_name(name); diff --git a/src/include/acpi/acpigen.h b/src/include/acpi/acpigen.h index 15af019..7b1141c 100644 --- a/src/include/acpi/acpigen.h +++ b/src/include/acpi/acpigen.h @@ -312,8 +312,6 @@ void acpigen_write_string(const char *string); void acpigen_write_name_unicode(const char *name, const char *string); void acpigen_write_name(const char *name); -void acpigen_write_name_zero(const char *name); -void acpigen_write_name_one(const char *name); void acpigen_write_name_string(const char *name, const char *string); void acpigen_write_name_dword(const char *name, uint32_t val); void acpigen_write_name_qword(const char *name, uint64_t val);