Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/libgfxinit/+/48761 )
Change subject: gma: Fix setting of `Raw Clock` scratchpad ......................................................................
gma: Fix setting of `Raw Clock` scratchpad
On some platforms, we determine the `Raw Clock` frequency at runtime. Make sure that we write the up-to-date value in PCH_RAWCLK_FREQ.
Change-Id: I50c299f6861ef313f2f11d146c4efa7204d53296 Signed-off-by: Nico Huber nico.h@gmx.de --- M common/hw-gfx-gma.adb 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/61/48761/1
diff --git a/common/hw-gfx-gma.adb b/common/hw-gfx-gma.adb index 9157bbe..3305aeb 100644 --- a/common/hw-gfx-gma.adb +++ b/common/hw-gfx-gma.adb @@ -538,7 +538,7 @@ Registers.Unset_And_Set_Mask (Register => Registers.PCH_RAWCLK_FREQ, Mask_Unset => PCH_RAWCLK_FREQ_MASK, - Mask_Set => PCH_RAWCLK_FREQ (Config.Default_RawClk_Freq)); + Mask_Set => PCH_RAWCLK_FREQ (Config.Raw_Clock)); end if;
Initialized := True;
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/48761 )
Change subject: gma: Fix setting of `Raw Clock` scratchpad ......................................................................
Patch Set 1: Code-Review+2
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/48761 )
Change subject: gma: Fix setting of `Raw Clock` scratchpad ......................................................................
Patch Set 1: Code-Review+2
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/48761 )
Change subject: gma: Fix setting of `Raw Clock` scratchpad ......................................................................
Patch Set 1: Verified+1
Nico Huber has submitted this change. ( https://review.coreboot.org/c/libgfxinit/+/48761 )
Change subject: gma: Fix setting of `Raw Clock` scratchpad ......................................................................
gma: Fix setting of `Raw Clock` scratchpad
On some platforms, we determine the `Raw Clock` frequency at runtime. Make sure that we write the up-to-date value in PCH_RAWCLK_FREQ.
Change-Id: I50c299f6861ef313f2f11d146c4efa7204d53296 Signed-off-by: Nico Huber nico.h@gmx.de Reviewed-on: https://review.coreboot.org/c/libgfxinit/+/48761 Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Michael Niewöhner foss@mniewoehner.de --- M common/hw-gfx-gma.adb 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: Nico Huber: Verified Angel Pons: Looks good to me, approved Michael Niewöhner: Looks good to me, approved
diff --git a/common/hw-gfx-gma.adb b/common/hw-gfx-gma.adb index 9157bbe..3305aeb 100644 --- a/common/hw-gfx-gma.adb +++ b/common/hw-gfx-gma.adb @@ -538,7 +538,7 @@ Registers.Unset_And_Set_Mask (Register => Registers.PCH_RAWCLK_FREQ, Mask_Unset => PCH_RAWCLK_FREQ_MASK, - Mask_Set => PCH_RAWCLK_FREQ (Config.Default_RawClk_Freq)); + Mask_Set => PCH_RAWCLK_FREQ (Config.Raw_Clock)); end if;
Initialized := True;
-
Angel Pons (Code Review) -
Michael Niewöhner (Code Review)
-
Nico Huber (Code Review)