[M] Change in coreboot[main]: soc/mediatek: Add support for MediaTek firmware support package

[Yidi Lin (Code Review)]

Attention is currently required from: Hung-Te Lin, Yu-Ping Wu.

Yidi Lin has posted comments on this change by Yidi Lin. ( https://review.coreboot.org/c/coreboot/+/85665?usp=email )

Change subject: soc/mediatek: Add support for MediaTek firmware support package
......................................................................

Patch Set 5:

(7 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/85665/comment/6c3a1968_4f4fbcf5?usp... :
PS2, Line 10: firmeware
> firmware

Done

https://review.coreboot.org/c/coreboot/+/85665/comment/dc1b1ce3_68033776?usp... :
PS2, Line 11: includes
> include

Done

File src/soc/mediatek/common/mtk_fsp.c:

https://review.coreboot.org/c/coreboot/+/85665/comment/f4432912_fefce9d5?usp... :
PS2, Line 19: void
> `enum fsp_phase phase`

Done

https://review.coreboot.org/c/coreboot/+/85665/comment/3aaf959f_d7cc9ed5?usp... :
PS2, Line 36: mtk_fsp_init();
> I think we should return an error here. […]

Done

https://review.coreboot.org/c/coreboot/+/85665/comment/9e9dc85b_7d4671d6?usp... :
PS2, Line 89: 		mtk_fsp_init();
> I think we should return an error here. […]

Done

https://review.coreboot.org/c/coreboot/+/85665/comment/19fe7183_eaf25af5?usp... :
PS2, Line 92: prog_set_entry(&fsp, prog_entry(&fsp), intf);
> `prog_set_arg(&fsp, intf)`. Otherwise you're just setting `prog->entry` to `prog->entry`.

`prog_set_entry` should be sufficient.

```
static inline void prog_set_entry(struct prog *prog, void *e, void *arg)
{
  prog->entry = e;
  prog->arg = arg;
}
```

https://review.coreboot.org/c/coreboot/+/85665/comment/e7324101_6927988e?usp... :
PS2, Line 100: d
> #x

Done