Attention is currently required from: Philipp Deppenwiese, Jonathan Zhang, Johnny Lin, Julius Werner, Arthur Heymans, Deomid "rojer" Ryabkov.
Christian Walter has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51099 )
Change subject: lib/cbfs.c: Fix return value of failure to measure
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
Patchset:
PS1:
This error case is most likely a TPM communication issue or something like that, it's not really rel […]
True - you got it wrong Philipp. Dieing is not an option here because you brick machines which have measured boot enabled, and the TPM starts failing for what-ever reasons.
That's okay for me for now.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51099
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifd20e543d3b30de045c0656eccdcc494c2fb10ce
Gerrit-Change-Number: 51099
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Deomid "rojer" Ryabkov
rojer9@fb.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jonathan Zhang
jonzhang@fb.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Attention: Jonathan Zhang
jonzhang@fb.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Deomid "rojer" Ryabkov
rojer9@fb.com
Gerrit-Comment-Date: Tue, 02 Mar 2021 12:08:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment