Attention is currently required from: Arthur Heymans, Kapil Porwal, Nick Vaccaro, sridhar siricilla.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80362?usp=email )
Change subject: soc/intel/cmn/sa: Add APIs into System Agent (SA) common code ......................................................................
Patch Set 7:
(4 comments)
File src/soc/intel/common/block/systemagent/systemagent.c:
https://review.coreboot.org/c/coreboot/+/80362/comment/a35555b0_75aa3486 : PS6, Line 327: const struct device *dev
SA is nothing but PCI_0_00_0 aka host bridge. […]
Acknowledged
https://review.coreboot.org/c/coreboot/+/80362/comment/f5d0161b_c27c5290 : PS6, Line 340: BIOS_DEBUG
Probably should be BIOS_ERR if CONFIG_ECAM_MMCONF_SUPPORT (that's always the case on modern HW)?
Acknowledged
https://review.coreboot.org/c/coreboot/+/80362/comment/7fb0938a_832a7b11 : PS6, Line 346: 4 * ((uint64_t)GiB);
'4ull * GiB' looks better IMO.
Acknowledged
https://review.coreboot.org/c/coreboot/+/80362/comment/c8290daf_47757ee6 : PS6, Line 367: BIOS_DEBUG
BIOS_ERR
Acknowledged