Hello Kyösti Mälkki, Swift Geek (Sebastian Grzywna), Paul Menzel, Bill XIE,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/38574
to review the following change.
Change subject: mb/lenovo/t400: Correct display port list for R500 variant ......................................................................
mb/lenovo/t400: Correct display port list for R500 variant
The second digital display connector is unused, but strapped as if it were used.
Versions with a discrete GPU seem to use PM45 (i.e. no IGD), so we can ignore these.
Based on schematics only, not tested.
Change-Id: Ibb47fdeef2adb9c574b7f3ec8e2b1d61d28f21da Signed-off-by: Nico Huber nico.h@gmx.de --- M src/mainboard/lenovo/t400/variants/r500/gma-mainboard.ads 1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/38574/1
diff --git a/src/mainboard/lenovo/t400/variants/r500/gma-mainboard.ads b/src/mainboard/lenovo/t400/variants/r500/gma-mainboard.ads index 680dd1b..8a72a31 100644 --- a/src/mainboard/lenovo/t400/variants/r500/gma-mainboard.ads +++ b/src/mainboard/lenovo/t400/variants/r500/gma-mainboard.ads @@ -23,7 +23,6 @@ ports : constant Port_List := (DP1, HDMI1, - HDMI2, Analog, Internal, others => Disabled);
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38574 )
Change subject: mb/lenovo/t400: Correct display port list for R500 variant ......................................................................
Patch Set 1: Code-Review+2
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38574 )
Change subject: mb/lenovo/t400: Correct display port list for R500 variant ......................................................................
Patch Set 1: Code-Review+1
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38574 )
Change subject: mb/lenovo/t400: Correct display port list for R500 variant ......................................................................
Patch Set 1: Code-Review+2
Tested on Intel-only model. The DVI port on the dock is not functional.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38574 )
Change subject: mb/lenovo/t400: Correct display port list for R500 variant ......................................................................
Patch Set 1:
Patch Set 1: Code-Review+2
Tested on Intel-only model. The DVI port on the dock is not functional.
Do you mean that this change fixes it?
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38574 )
Change subject: mb/lenovo/t400: Correct display port list for R500 variant ......................................................................
Patch Set 1:
Patch Set 1:
Patch Set 1: Code-Review+2
Tested on Intel-only model. The DVI port on the dock is not functional.
Do you mean that this change fixes it?
No this port is simply not functional, so no reason to have it probed by libgfxinit.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38574 )
Change subject: mb/lenovo/t400: Correct display port list for R500 variant ......................................................................
Patch Set 1:
Patch Set 1:
Patch Set 1:
Patch Set 1: Code-Review+2
Tested on Intel-only model. The DVI port on the dock is not functional.
Do you mean that this change fixes it?
No this port is simply not functional, so no reason to have it probed by libgfxinit.
D'oh, right. It's not wired up at all.
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38574 )
Change subject: mb/lenovo/t400: Correct display port list for R500 variant ......................................................................
mb/lenovo/t400: Correct display port list for R500 variant
The second digital display connector is unused, but strapped as if it were used.
Versions with a discrete GPU seem to use PM45 (i.e. no IGD), so we can ignore these.
Based on schematics only, not tested.
Change-Id: Ibb47fdeef2adb9c574b7f3ec8e2b1d61d28f21da Signed-off-by: Nico Huber nico.h@gmx.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/38574 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-by: Arthur Heymans arthur@aheymans.xyz --- M src/mainboard/lenovo/t400/variants/r500/gma-mainboard.ads 1 file changed, 0 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Kyösti Mälkki: Looks good to me, but someone else must approve Arthur Heymans: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/src/mainboard/lenovo/t400/variants/r500/gma-mainboard.ads b/src/mainboard/lenovo/t400/variants/r500/gma-mainboard.ads index 680dd1b..8a72a31 100644 --- a/src/mainboard/lenovo/t400/variants/r500/gma-mainboard.ads +++ b/src/mainboard/lenovo/t400/variants/r500/gma-mainboard.ads @@ -23,7 +23,6 @@ ports : constant Port_List := (DP1, HDMI1, - HDMI2, Analog, Internal, others => Disabled);
-
Angel Pons (Code Review) -
Arthur Heymans (Code Review)
-
Kyösti Mälkki (Code Review)
-
Nico Huber (Code Review)
-
Patrick Georgi (Code Review)