Attention is currently required from: Furquan Shaikh, Paul Menzel, Tim Wawrzynczak, Rizwan Qureshi.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56751 )
Change subject: drivers/wifi/generic: Enable DSM ACPI entries for Intel WIFI card
......................................................................
Patch Set 11:
(2 comments)
File src/drivers/wifi/generic/acpi.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-126186):
https://review.coreboot.org/c/coreboot/+/56751/comment/31303216_488ff997
PS11, Line 50: void wifi_write_dsm(const char *uuid, void (**callbacks)(void *), size_t count,
function definition argument 'void' should also have an identifier name
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-126186):
https://review.coreboot.org/c/coreboot/+/56751/comment/082cf0be_e3d48f90
PS11, Line 50: void wifi_write_dsm(const char *uuid, void (**callbacks)(void *), size_t count,
function definition argument 'void *' should also have an identifier name
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56751
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie154edf188531fe6c260274edaa694cf3b3605d3
Gerrit-Change-Number: 56751
Gerrit-PatchSet: 11
Gerrit-Owner: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-CC: Jamie Chen
jamie.chen@intel.com
Gerrit-CC: Janiex Tu
janiex.tu@intel.corp-partner.google.com
Gerrit-CC: Matt Chen
matt.chen@intel.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Sherry An
sherry.an@intel.com
Gerrit-CC: Simon Yang
simon1.yang@intel.com
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Comment-Date: Fri, 13 Aug 2021 10:32:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment