DaLao has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40723 )
Change subject: mb/lenovo/t440p: update VBT ......................................................................
mb/lenovo/t440p: update VBT
Update T440p's VBT from to version 2179. Extracted from the latest bios update file: T440p's bios image https://download.lenovo.com/pccbbs/mobiles/gluj42us.iso
Test: boot t440p with both SeaBIOS and Tianocore payloads, verify dp output and backlight control all works under both Linux and Windows.
Signed-off-by: dalao dalao@tutanota.com Change-Id: If8669b8de6fa0801e261138651b8b2cf50432a70 --- M src/mainboard/lenovo/t440p/data.vbt 1 file changed, 0 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/40723/1
diff --git a/src/mainboard/lenovo/t440p/data.vbt b/src/mainboard/lenovo/t440p/data.vbt index 1b2cd87..79077cc 100644 --- a/src/mainboard/lenovo/t440p/data.vbt +++ b/src/mainboard/lenovo/t440p/data.vbt Binary files differ
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40723 )
Change subject: mb/lenovo/t440p: update VBT ......................................................................
Patch Set 1: Code-Review+1
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40723 )
Change subject: mb/lenovo/t440p: update VBT ......................................................................
Patch Set 1:
(5 comments)
https://review.coreboot.org/c/coreboot/+/40723/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40723/1//COMMIT_MSG@2 PS1, Line 2: dalao Please set up a full name (even pseudonym).
$ git config --global user.name "…" $ git commit --amend --author="… dalao@tutanota.com"
https://review.coreboot.org/c/coreboot/+/40723/1//COMMIT_MSG@7 PS1, Line 7: mb/lenovo/t440p: update VBT Update VBT to version 2179
https://review.coreboot.org/c/coreboot/+/40723/1//COMMIT_MSG@9 PS1, Line 9: from to The current version is missing.
https://review.coreboot.org/c/coreboot/+/40723/1//COMMIT_MSG@9 PS1, Line 9: Extracted Please mention the tool, you used.
https://review.coreboot.org/c/coreboot/+/40723/1//COMMIT_MSG@12 PS1, Line 12: Please mention what problem is fixed now, or what differs.
Hello build bot (Jenkins), Angel Pons, Alexander Couzens, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40723
to look at the new patch set (#2).
Change subject: mb/lenovo/t440p: update VBT to version 2179 ......................................................................
mb/lenovo/t440p: update VBT to version 2179
Update T440p's VBT from version 1215 to version 2179. Extracted using VBiosFinder (https://github.com/coderobe/VBiosFinder) from the latest bios update file: https://download.lenovo.com/pccbbs/mobiles/gluj42us.iso
The new version solve the problem that DP output was broken under Windows.
Test: boot t440p with both SeaBIOS and Tianocore payloads, verify dp output and backlight control all works under both Linux and Windows.
Signed-off-by: dalao dalao@tutanota.com Change-Id: If8669b8de6fa0801e261138651b8b2cf50432a70 --- M src/mainboard/lenovo/t440p/data.vbt 1 file changed, 0 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/40723/2
Hello build bot (Jenkins), Angel Pons, Alexander Couzens, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40723
to look at the new patch set (#3).
Change subject: mb/lenovo/t440p: update VBT to version 2179 ......................................................................
mb/lenovo/t440p: update VBT to version 2179
Update T440p's VBT from version 1215 to version 2179. Extracted using VBiosFinder (https://github.com/coderobe/VBiosFinder) from the latest bios update file: https://download.lenovo.com/pccbbs/mobiles/gluj42us.iso
The new version solve the problem that DP output was broken under Windows.
Test: boot t440p with both SeaBIOS and Tianocore payloads, verify dp output and backlight control all works under both Linux and Windows.
Signed-off-by: Da Lao dalao@tutanota.com Change-Id: If8669b8de6fa0801e261138651b8b2cf50432a70 --- M src/mainboard/lenovo/t440p/data.vbt 1 file changed, 0 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/40723/3
DaLao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40723 )
Change subject: mb/lenovo/t440p: update VBT to version 2179 ......................................................................
Patch Set 3:
(5 comments)
Patch Set 1:
(5 comments)
Thank you and all done.
https://review.coreboot.org/c/coreboot/+/40723/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40723/1//COMMIT_MSG@2 PS1, Line 2: dalao
Please set up a full name (even pseudonym). […]
Done
https://review.coreboot.org/c/coreboot/+/40723/1//COMMIT_MSG@7 PS1, Line 7: mb/lenovo/t440p: update VBT
Update VBT to version 2179
Done
https://review.coreboot.org/c/coreboot/+/40723/1//COMMIT_MSG@9 PS1, Line 9: from to
The current version is missing.
Done
https://review.coreboot.org/c/coreboot/+/40723/1//COMMIT_MSG@9 PS1, Line 9: Extracted
Please mention the tool, you used.
Done
https://review.coreboot.org/c/coreboot/+/40723/1//COMMIT_MSG@12 PS1, Line 12:
Please mention what problem is fixed now, or what differs.
Done
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40723 )
Change subject: mb/lenovo/t440p: update VBT to version 2179 ......................................................................
Patch Set 3: Code-Review+1
Attention is currently required from: Da Lao. Forkoz has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40723 )
Change subject: mb/lenovo/t440p: update VBT to version 2179 ......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3: Wait... this is not merged? I just did so again and my version is slightly older. They have 2.54, I used 2.50. Now I'm going to try their VBT!
Attention is currently required from: Da Lao. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40723 )
Change subject: mb/lenovo/t440p: update VBT to version 2179 ......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/40723/comment/4162b0d1_809e4793 PS3, Line 14: solve solves
Attention is currently required from: Da Lao. Forkoz has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40723 )
Change subject: mb/lenovo/t440p: update VBT to version 2179 ......................................................................
Patch Set 3: Code-Review+1
Attention is currently required from: Da Lao. Forkoz has uploaded a new patch set (#4) to the change originally created by Da Lao. ( https://review.coreboot.org/c/coreboot/+/40723 )
Change subject: mb/lenovo/t440p: update VBT to version 2179 ......................................................................
mb/lenovo/t440p: update VBT to version 2179
Update T440p's VBT from version 1215 to version 2179. Extracted using VBiosFinder (https://github.com/coderobe/VBiosFinder) from the latest bios update file: https://download.lenovo.com/pccbbs/mobiles/gluj42us.iso
The new version solves the problem that DP output was broken under Windows.
Test: boot t440p with both SeaBIOS and Tianocore payloads, verify dp output and backlight control all works under both Linux and Windows.
Signed-off-by: Da Lao dalao@tutanota.com Change-Id: If8669b8de6fa0801e261138651b8b2cf50432a70 --- M src/mainboard/lenovo/t440p/data.vbt 1 file changed, 0 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/40723/4
Attention is currently required from: Da Lao, Angel Pons. Forkoz has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40723 )
Change subject: mb/lenovo/t440p: update VBT to version 2179 ......................................................................
Patch Set 4:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/40723/comment/6e049b71_cadb98a2 PS3, Line 14: solve
solves
I added the S. Not sure if that works. Original submitter is probably gone.
Attention is currently required from: Da Lao, Forkoz, Angel Pons. Forkoz has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40723 )
Change subject: mb/lenovo/t440p: update VBT to version 2179 ......................................................................
Patch Set 4:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/40723/comment/0276880a_5f9aed97 PS3, Line 14: solve
I added the S. Not sure if that works. Original submitter is probably gone.
Done
Attention is currently required from: Da Lao, Forkoz. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40723 )
Change subject: mb/lenovo/t440p: update VBT to version 2179 ......................................................................
Patch Set 4:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/40723/comment/dbb0ff37_88cb3735 PS3, Line 14: solve
Done
Should be good enough, though the build failure looks odd.
In case you didn't know yet: our gerrit guidelines [1] say "don't modify other people's patches without their consent". As this change is not part of a patch train and has been sitting here for about 10 months without any updates, that you've updated its commit message is not a big deal. Still, please keep this in mind in the future.
[1]: https://doc.coreboot.org/getting_started/gerrit_guidelines.html
Attention is currently required from: Da Lao, Angel Pons. Forkoz has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40723 )
Change subject: mb/lenovo/t440p: update VBT to version 2179 ......................................................................
Patch Set 4:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/40723/comment/947d7ac9_d864b18e PS3, Line 14: solve
Should be good enough, though the build failure looks odd. […]
I'll keep that in mind. Still new to this. I overrode a previous commit even...
The failure is on vboot: make[2]: *** [Makefile:999: /cb-build/coreboot-gerrit.0/default/sharedutils/vboot_lib/futility/futility] Error 1
All this does is update the binary of the vbt. The bot is strange. It was failing on one of my patches too saying I omitted signed-off-by and yet I had specifically changed the commit message to include the line. I think I reran it a few times before it took it.
Attention is currently required from: Da Lao, Forkoz. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40723 )
Change subject: mb/lenovo/t440p: update VBT to version 2179 ......................................................................
Patch Set 4:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/40723/comment/210a864d_a9a408c6 PS3, Line 14: solve
Should be good enough, though the build failure looks odd. […]
I would try to rebase atop master (there's a "REBASE" button on gerrit's interface) to see if the build issue gets resolved.
Attention is currently required from: Da Lao, Angel Pons. Forkoz has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40723 )
Change subject: mb/lenovo/t440p: update VBT to version 2179 ......................................................................
Patch Set 4:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/40723/comment/548904f5_392a6b11 PS3, Line 14: solve
I would try to rebase atop master (there's a "REBASE" button on gerrit's interface) to see if the bu […]
It does not give me the option. Possibly since it's someone else's commit.
Attention is currently required from: Da Lao, Iru Cai. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40723 )
Change subject: mb/lenovo/t440p: update VBT to version 2179 ......................................................................
Patch Set 5: Code-Review+2
Attention is currently required from: Da Lao, Angel Pons, Iru Cai. Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40723 )
Change subject: mb/lenovo/t440p: update VBT to version 2179 ......................................................................
Patch Set 5: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40723 )
Change subject: mb/lenovo/t440p: update VBT to version 2179 ......................................................................
mb/lenovo/t440p: update VBT to version 2179
Update T440p's VBT from version 1215 to version 2179. Extracted using VBiosFinder (https://github.com/coderobe/VBiosFinder) from the latest bios update file: https://download.lenovo.com/pccbbs/mobiles/gluj42us.iso
The new version solves the problem that DP output was broken under Windows.
Test: boot t440p with both SeaBIOS and Tianocore payloads, verify dp output and backlight control all works under both Linux and Windows.
Signed-off-by: Da Lao dalao@tutanota.com Change-Id: If8669b8de6fa0801e261138651b8b2cf50432a70 Reviewed-on: https://review.coreboot.org/c/coreboot/+/40723 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Patrick Georgi pgeorgi@google.com Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Jamal Wright Crabstorage@getbackinthe.kitchen --- M src/mainboard/lenovo/t440p/data.vbt 1 file changed, 0 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved Paul Menzel: Looks good to me, but someone else must approve Angel Pons: Looks good to me, approved Jamal Wright: Looks good to me, but someone else must approve
diff --git a/src/mainboard/lenovo/t440p/data.vbt b/src/mainboard/lenovo/t440p/data.vbt index 1b2cd87..79077cc 100644 --- a/src/mainboard/lenovo/t440p/data.vbt +++ b/src/mainboard/lenovo/t440p/data.vbt Binary files differ
-
Angel Pons (Code Review) -
DaLao (Code Review)
-
Forkoz (Code Review)
-
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)