Attention is currently required from: Hung-Te Lin, Kiwi Liu, Mengqi Zhang, Paul Menzel, Yidi Lin.
Yu-Ping Wu has posted comments on this change by Kiwi Liu. ( https://review.coreboot.org/c/coreboot/+/84298?usp=email )
Change subject: soc/mediatek/common: Correct src clk frq to 400 MHz for eMMMC clk of 400 kHz
......................................................................
Patch Set 15:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84298/comment/76326f5f_129960dd?usp... :
PS15, Line 7: Correct src clk frq to 400 MHz for eMMMC clk
: of 400 kHz
Looks like it's too long. How about `Correct eMMC src clk frequency to 400 MHz`?
File src/soc/mediatek/common/msdc.c:
https://review.coreboot.org/c/coreboot/+/84298/comment/bdac5a6a_2a7efa52?usp... :
PS15, Line 432: 400 * 1000 * 1000
400 * MHz
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84298?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I9c8836b23fb21e9b0bdc80fbe85142ea0fa5e381
Gerrit-Change-Number: 84298
Gerrit-PatchSet: 15
Gerrit-Owner: Kiwi Liu
kiwi.liu@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Mengqi Zhang
mengqi.zhang@mediatek.corp-partner.google.com
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Kiwi Liu
kiwi.liu@mediatek.corp-partner.google.com
Gerrit-Attention: Mengqi Zhang
mengqi.zhang@mediatek.corp-partner.google.com
Gerrit-Attention: Yidi Lin
yidilin@google.com
Gerrit-Comment-Date: Fri, 13 Sep 2024 08:56:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No