Attention is currently required from: Angel Pons, Balaji Manigandan, Kapil Porwal, Karthik Ramasubramanian, Maulik Vaghela, Meera Ravindranath, Nick Vaccaro, Patrick Rudolph, Raj Astekar, Reka Norman, Subrata Banik, Tarun Tuli, Tim Wawrzynczak.
Tim Crawford has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52731?usp=email )
Change subject: soc/common/smbus: Add support for reading spd data via smbus for DDR5
......................................................................
Patch Set 14:
(1 comment)
File src/soc/intel/common/block/smbus/smbuslib.c:
https://review.coreboot.org/c/coreboot/+/52731/comment/2a73ba07_f41fa4e2 :
PS13, Line 10: { 0, 1 }, /* General Configuration section */
: { 2, 2 }, /* General Configuration section */
: { 3, 47 }, /* General Configuration section */
This range looks contiguous to me, does the following not work? […]
If this code is correct, then these are not contiguous. In fact, the second line doesn't do anything.
{ 2, 2 }, /* General Configuration section */
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52731?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic5e6c58f255bef86b68ce90a4f853bf4e7c7ccfe
Gerrit-Change-Number: 52731
Gerrit-PatchSet: 14
Gerrit-Owner: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Maulik Vaghela
maulikvaghela@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.com
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Reka Norman
rekanorman@chromium.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-CC: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Tim Crawford
tcrawford@system76.com
Gerrit-Attention: Maulik Vaghela
maulikvaghela@google.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Reka Norman
rekanorman@chromium.org
Gerrit-Attention: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Raj Astekar
raj.astekar@intel.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Tue, 01 Aug 2023 20:18:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-MessageType: comment