Attention is currently required from: Michał Kopeć, Michał Żygowski, Paul Menzel, Sergii Dmytruk.
Krystian Hebel has posted comments on this change by Krystian Hebel. ( https://review.coreboot.org/c/coreboot/+/82555?usp=email )
Change subject: mb/qemu-{i440fx,q35}/rom_media.c: add code for writable flash
......................................................................
Patch Set 8:
(2 comments)
File src/mainboard/emulation/qemu-i440fx/rom_media.c:
https://review.coreboot.org/c/coreboot/+/82555/comment/a9d82572_2fe6f905?usp... :
PS3, Line 31: to write to the log
Flash based event log only, the one enabled with CONFIG_ELOG. […]
Done
File src/mainboard/emulation/qemu-i440fx/rom_media.c:
https://review.coreboot.org/c/coreboot/+/82555/comment/94db5778_46cae2ec?usp... :
PS4, Line 158: flash_ops
`mdev_readat` is used for all 3 options, it is copied in line 131 from `mem_rdev_rw_ops`.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/82555?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3ab9f22c6165064a769881d4be5eab13a0a2f519
Gerrit-Change-Number: 82555
Gerrit-PatchSet: 8
Gerrit-Owner: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Reviewer: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Attention: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Comment-Date: Thu, 18 Jul 2024 11:24:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Krystian Hebel
krystian.hebel@3mdeb.com