Attention is currently required from: Kapil Porwal, Matt DeVillier, Nick Vaccaro, Sean Rhodes.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80486?usp=email )
Change subject: soc/intel/alderlake: Correctly set Usb4CmMode
......................................................................
Patch Set 4:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80486/comment/705a3112_c9cf13e2 :
PS4, Line 7: Correctly set Usb4CmMode
Maybe more specific:
Sync UPD Usb4CmMode with Kconfig SOFTWARE_CONNECTION_MANAGER
or similar.
https://review.coreboot.org/c/coreboot/+/80486/comment/4a72f5a0_acb9d1fb :
PS4, Line 11: mismatched.
Should fit on the line above in 75 characters per line.
https://review.coreboot.org/c/coreboot/+/80486/comment/4cb7c70b_36c896e8 :
PS4, Line 13: timeout
time out
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80486?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I8a99db165301ce08caf55aac0e33ca1994559d62
Gerrit-Change-Number: 80486
Gerrit-PatchSet: 4
Gerrit-Owner: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Mon, 19 Feb 2024 08:23:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment