Change in coreboot[master]: mb/google/dedede/board_info.c: Clean-up includes

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41541 )

Change subject: mb/google/dedede/board_info.c: Clean-up includes
......................................................................

mb/google/dedede/board_info.c: Clean-up includes

Change-Id: I7e8109870168db7f477f205a0b3020b7b2be5f5f
Signed-off-by: Elyes HAOUAS 
---
M src/mainboard/google/dedede/board_info.c
1 file changed, 0 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/41541/1

diff --git a/src/mainboard/google/dedede/board_info.c b/src/mainboard/google/dedede/board_info.c
index 3289cb4..fdb4b5f 100644
--- a/src/mainboard/google/dedede/board_info.c
+++ b/src/mainboard/google/dedede/board_info.c
@@ -1,9 +1,7 @@
 /* SPDX-License-Identifier: GPL-2.0-or-later */

#include <baseboard/variants.h>
-#include <console/console.h>
 #include <ec/google/chromeec/ec.h>
-#include <smbios.h>

int board_info_get_fw_config(uint32_t *fw_config)
 {

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41541 )

Change subject: mb/google/dedede/board_info.c: Clean-up includes
......................................................................

Patch Set 3: Code-Review+1

(2 comments)

https://review.coreboot.org/c/coreboot/+/41541/3//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/41541/3//COMMIT_MSG@7 
PS3, Line 7: Clean-up
Clean up

https://review.coreboot.org/c/coreboot/+/41541/3//COMMIT_MSG@7 
PS3, Line 7: mb/google/dedede/board_info.c: Clean-up includes
Remove unused includes

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41541 )

Change subject: mb/google/dedede/board_info.c: Clean-up includes
......................................................................

Patch Set 3:

(2 comments)

Thank you

https://review.coreboot.org/c/coreboot/+/41541/3//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/41541/3//COMMIT_MSG@7 
PS3, Line 7: Clean-up
> Clean up

Done

https://review.coreboot.org/c/coreboot/+/41541/3//COMMIT_MSG@7 
PS3, Line 7: mb/google/dedede/board_info.c: Clean-up includes
> Remove unused includes

Done

Change in coreboot[master]: mb/google/dedede/board_info.c: Clean up

[HAOUAS Elyes (Code Review)]

Hello build bot (Jenkins), Paul Menzel,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/41541

to look at the new patch set (#4).

Change subject: mb/google/dedede/board_info.c: Clean up
......................................................................

mb/google/dedede/board_info.c: Clean up

Remove unused includes

Change-Id: I7e8109870168db7f477f205a0b3020b7b2be5f5f
Signed-off-by: Elyes HAOUAS 
---
M src/mainboard/google/dedede/board_info.c
1 file changed, 0 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/41541/4

Change in coreboot[master]: mb/google/dedede/board_info.c: Clean up

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41541 )

Change subject: mb/google/dedede/board_info.c: Clean up
......................................................................

Patch Set 5: Code-Review+1

Not sure if this file is currently WIP. AFAIK dlaurie has some patches about fw_config in gerrit

Change in coreboot[master]: mb/google/dedede/board_info.c: Clean up

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41541 )

Change subject: mb/google/dedede/board_info.c: Clean up
......................................................................

Patch Set 6: Code-Review+2

Change in coreboot[master]: mb/google/dedede/board_info.c: Clean up

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/41541 )

Change subject: mb/google/dedede/board_info.c: Clean up
......................................................................

mb/google/dedede/board_info.c: Clean up

Remove unused includes

Change-Id: I7e8109870168db7f477f205a0b3020b7b2be5f5f
Signed-off-by: Elyes HAOUAS 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/41541
Reviewed-by: Angel Pons 
Reviewed-by: Paul Menzel 
Tested-by: build bot (Jenkins) 
---
M src/mainboard/google/dedede/board_info.c
1 file changed, 0 insertions(+), 2 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Paul Menzel: Looks good to me, but someone else must approve
  Angel Pons: Looks good to me, approved

diff --git a/src/mainboard/google/dedede/board_info.c b/src/mainboard/google/dedede/board_info.c
index 3289cb4..fdb4b5f 100644
--- a/src/mainboard/google/dedede/board_info.c
+++ b/src/mainboard/google/dedede/board_info.c
@@ -1,9 +1,7 @@
 /* SPDX-License-Identifier: GPL-2.0-or-later */

#include <baseboard/variants.h>
-#include <console/console.h>
 #include <ec/google/chromeec/ec.h>
-#include <smbios.h>

int board_info_get_fw_config(uint32_t *fw_config)
 {

Change in coreboot[master]: mb/google/dedede/board_info.c: Clean up

[9elements QA (Code Review)]

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41541 )

Change subject: mb/google/dedede/board_info.c: Clean up
......................................................................

Patch Set 9:

Automatic boot test returned (PASS/FAIL/TOTAL): 4/0/4
Emulation targets:
"QEMU x86 q35/ich9" using payload TianoCore : SUCCESS : https://lava.9esec.io/r/5167
"QEMU x86 q35/ich9" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/5166
"QEMU x86 i440fx/piix4" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/5165
"QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/5164

Please note: This test is under development and might not be accurate at all!