Attention is currently required from: Hope Wang, Hung-Te Lin, Jarried Lin, Yu-Ping Wu.
Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85129?usp=email )
Change subject: soc/mediatek/mt8196: Add PMIC mt6373 driver ......................................................................
Patch Set 30:
(8 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/85129/comment/b38414cf_b2617d39?usp... : PS30, Line 9: mt6373 MT6373
https://review.coreboot.org/c/coreboot/+/85129/comment/917582e5_1a7b6a6e?usp... : PS30, Line 9: add Add
https://review.coreboot.org/c/coreboot/+/85129/comment/5030db3a_1e1c3575?usp... : PS30, Line 10: api API
https://review.coreboot.org/c/coreboot/+/85129/comment/9bd4eb54_6cd38ce6?usp... : PS30, Line 10: SD power powering on SD card
https://review.coreboot.org/c/coreboot/+/85129/comment/54a88173_028e76c2?usp... : PS30, Line 11: add implement interface for vcn33_3 Can we just say `Add regulator API for VCN33_3` ?
https://review.coreboot.org/c/coreboot/+/85129/comment/e365ddea_2f353544?usp... : PS30, Line 12: enable Enable
https://review.coreboot.org/c/coreboot/+/85129/comment/afa7e254_f59f4450?usp... : PS30, Line 13: 5. add MT6373 LDO enable api Add
https://review.coreboot.org/c/coreboot/+/85129/comment/11576a09_0484b7e0?usp... : PS30, Line 13: api API