Change in coreboot[master]: mb/ti/beaglebone: Init UART in early init

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Sam Lewis (Code Review)

11 Aug 2020 11 Aug '20

11:03 a.m.

Sam Lewis has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44380 )

Change subject: mb/ti/beaglebone: Init UART in early init ......................................................................

mb/ti/beaglebone: Init UART in early init

The console is initialized before mainboard_init, so the peripheral should be initialized in bootblock_mainboard_early_init rather than bootblock_mainboard_init.

Change-Id: I9f4ba29798eb0b1efea76f5ade4a234fb35a2f83 Signed-off-by: Sam Lewis sam.vr.lewis@gmail.com --- M src/mainboard/ti/beaglebone-black/bootblock.c 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/44380/1

diff --git a/src/mainboard/ti/beaglebone-black/bootblock.c b/src/mainboard/ti/beaglebone-black/bootblock.c index ca1a390..b7b0ee9 100644 --- a/src/mainboard/ti/beaglebone-black/bootblock.c +++ b/src/mainboard/ti/beaglebone-black/bootblock.c @@ -9,7 +9,7 @@

#include "leds.h"

-void bootblock_mainboard_init(void) +void bootblock_mainboard_early_init(void) { write32(&am335x_cm_wkup->wkup_gpio0, CM_ST_SW_WKUP | CM_FCLK_EN); write32(&am335x_cm_per->gpio1, CM_ST_SW_WKUP | CM_FCLK_EN);

Attachments:

attachment.htm (text/html — 2.6 KB)

Show replies by date

Sam Lewis (Code Review)

11 Aug 11 Aug

11:14 a.m.

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/44380

to look at the new patch set (#2).

Change subject: mb/ti/beaglebone: Init UART in early init ......................................................................

mb/ti/beaglebone: Init UART in early init

The console is initialized before mainboard_init, so the peripheral should be initialized in bootblock_mainboard_early_init rather than bootblock_mainboard_init.

Change-Id: I9f4ba29798eb0b1efea76f5ade4a234fb35a2f83 Signed-off-by: Sam Lewis sam.vr.lewis@gmail.com --- M src/mainboard/ti/beaglebone-black/bootblock.c 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/44380/2

Patrick Rudolph (Code Review)

13 Aug 13 Aug

4:59 a.m.

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44380 )

Change subject: mb/ti/beaglebone: Init UART in early init ......................................................................

Patch Set 5: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/44380 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9f4ba29798eb0b1efea76f5ade4a234fb35a2f83 Gerrit-Change-Number: 44380 Gerrit-PatchSet: 5 Gerrit-Owner: Sam Lewis sam.vr.lewis@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 13 Aug 2020 04:59:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Arthur Heymans (Code Review)

19 Aug 19 Aug

9:24 a.m.

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44380 )

Change subject: mb/ti/beaglebone: Init UART in early init ......................................................................

Patch Set 7: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/44380 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9f4ba29798eb0b1efea76f5ade4a234fb35a2f83 Gerrit-Change-Number: 44380 Gerrit-PatchSet: 7 Gerrit-Owner: Sam Lewis sam.vr.lewis@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 19 Aug 2020 09:24:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Sam Lewis (Code Review)

11:03 a.m.

Hello build bot (Jenkins), Arthur Heymans, Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/44380

to look at the new patch set (#8).

Change subject: mb/ti/beaglebone: Init UART in early init ......................................................................

mb/ti/beaglebone: Init UART in early init

The console is initialized before mainboard_init, so the peripheral should be initialized in bootblock_mainboard_early_init rather than bootblock_mainboard_init.

Change-Id: I9f4ba29798eb0b1efea76f5ade4a234fb35a2f83 Signed-off-by: Sam Lewis sam.vr.lewis@gmail.com --- M src/mainboard/ti/beaglebone/bootblock.c 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/44380/8

-- To view, visit https://review.coreboot.org/c/coreboot/+/44380 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9f4ba29798eb0b1efea76f5ade4a234fb35a2f83 Gerrit-Change-Number: 44380 Gerrit-PatchSet: 8 Gerrit-Owner: Sam Lewis sam.vr.lewis@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Patrick Georgi (Code Review)

9 Sep 9 Sep

10:48 a.m.

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44380 )

Change subject: mb/ti/beaglebone: Init UART in early init ......................................................................

Patch Set 8: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/44380 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9f4ba29798eb0b1efea76f5ade4a234fb35a2f83 Gerrit-Change-Number: 44380 Gerrit-PatchSet: 8 Gerrit-Owner: Sam Lewis sam.vr.lewis@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 09 Sep 2020 10:48:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

10:48 a.m.

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44380 )

Change subject: mb/ti/beaglebone: Init UART in early init ......................................................................

mb/ti/beaglebone: Init UART in early init

The console is initialized before mainboard_init, so the peripheral should be initialized in bootblock_mainboard_early_init rather than bootblock_mainboard_init.

Change-Id: I9f4ba29798eb0b1efea76f5ade4a234fb35a2f83 Signed-off-by: Sam Lewis sam.vr.lewis@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/44380 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Georgi pgeorgi@google.com --- M src/mainboard/ti/beaglebone/bootblock.c 1 file changed, 1 insertion(+), 1 deletion(-)

Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved

diff --git a/src/mainboard/ti/beaglebone/bootblock.c b/src/mainboard/ti/beaglebone/bootblock.c index ca1a390..b7b0ee9 100644 --- a/src/mainboard/ti/beaglebone/bootblock.c +++ b/src/mainboard/ti/beaglebone/bootblock.c @@ -9,7 +9,7 @@

#include "leds.h"

-- To view, visit https://review.coreboot.org/c/coreboot/+/44380 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9f4ba29798eb0b1efea76f5ade4a234fb35a2f83 Gerrit-Change-Number: 44380 Gerrit-PatchSet: 9 Gerrit-Owner: Sam Lewis sam.vr.lewis@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

1344

days inactive

1373

days old

coreboot-gerrit@coreboot.org

6 comments

4 participants

tags (0)

participants (4)

Arthur Heymans (Code Review)
Patrick Georgi (Code Review)
Patrick Rudolph (Code Review)
Sam Lewis (Code Review)