Attention is currently required from: Aseda Aboagye. Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52919 )
Change subject: chromeos/Kconfig: Add TPM20_CREATE_FWMP ......................................................................
Patch Set 2:
(1 comment)
File src/security/vboot/secdata_tpm.c:
https://review.coreboot.org/c/coreboot/+/52919/comment/07a50f55_d4d85120 PS1, Line 246: if (rv == TPM_E_NV_DEFINED) {
Negative. This scenario should be rare (e.g. […]
Sorry, I missed this was in _factory_initialized_tpm(). It might be more self explanatory if I was more perceptive.
My next question is if it wasn't defined we'd return from the function w/o calling set_firmware_space()? Basically if rv == TPM_SUCCESS or (rv != TPM_E_NV_DEFINED) we're returning early. Should the 'else' be 'else if (rv != TPM_SUCCESS)' or whatever the successful return value?