Attention is currently required from: Darius Goad, Patrick Rudolph. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57089 )
Change subject: cpu/intel: Make doubly sure we don't write to IA32_FEATURE_CTRL if its lock bit is set on a reset. ......................................................................
Patch Set 1:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/57089/comment/7eabab88_a8f84df7 PS1, Line 2: qeeg Please use *Darius Goad*.
$ git commit --amend --author="Darius Goad mszoopers@protonmail.com" $ git config --global user.name "Darius Goad mszoopers@protonmail.com"
https://review.coreboot.org/c/coreboot/+/57089/comment/6c3d2446_66525b8c PS1, Line 8: lock bit is set on a reset. Please shorten it, and remove the dot/period at the end. Maybe:
cpu/intel/model_1067x: Do not write to IA32_FEATURE_CTRL with lock bit set on reset
https://review.coreboot.org/c/coreboot/+/57089/comment/b7cbfa2a_8f117167 PS1, Line 9: Can you describe the problem first?
Patchset:
PS1: Welcome to coreboot!
File src/cpu/intel/model_1067x/mp_init.c:
https://review.coreboot.org/c/coreboot/+/57089/comment/1fb8bf55_a4acd1d5 PS1, Line 63: return; Why is this removed?