Vitaly Rodionov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61448 )
Change subject: drivers/i2c/cs35l53: Add driver for generating device in SSDT ......................................................................
Patch Set 2:
(4 comments)
File src/drivers/i2c/cs35l53/cs35l53.c:
https://review.coreboot.org/c/coreboot/+/61448/comment/e6761345_b9cb2d3a PS1, Line 69: if ((config->boost_peak_milliamp > 4500) ||
that open brace { should be on the previous line
Fixed
https://review.coreboot.org/c/coreboot/+/61448/comment/591fad61_b815eeda PS1, Line 82: acpi_dp_add_integer(dsd, "cirrus,gpio1-polarity-invert", config->gpio1_polarity_invert ? 1 : 0);
line over 96 characters
Fixed
https://review.coreboot.org/c/coreboot/+/61448/comment/60c9f248_dcdd0a76 PS1, Line 83: acpi_dp_add_integer(dsd, "cirrus,gpio1-output-enable", config->gpio1_output_enable ? 1 : 0);
line over 96 characters
Fixed
https://review.coreboot.org/c/coreboot/+/61448/comment/d09cd448_107be6fa PS1, Line 86: acpi_dp_add_integer(dsd, "cirrus,gpio2-output-enable", config->gpio2_output_enable ? 1 : 0);
line over 96 characters
Fixed