Attention is currently required from: Idwer Vollering, Paul Menzel, Felix Held.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/53996 )
Change subject: util/cbfstool: Do not set -D_XOPEN_SOURCE on FreeBSD
......................................................................
Patch Set 2:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/53996/comment/97440f70_1e94a257
PS1, Line 7: util/cbfstool: shuffle -D_XOPEN_SOURCE around to fix compilation on FreeBSD
How about: […]
Done
https://review.coreboot.org/c/coreboot/+/53996/comment/3542cbc0_f6aa2c2c
PS1, Line 8:
Nit: Please paste the error you got.
Done
Patchset:
PS2:
hm, is there a way to solve this that doesn't involve any os-specific hacks? this one checks for fre […]
I wonder what exactly needs -D_XOPEN_SOURCE=700
--
To view, visit
https://review.coreboot.org/c/coreboot/+/53996
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I45c02a21709160df44fc8da329f6c4a9bad24478
Gerrit-Change-Number: 53996
Gerrit-PatchSet: 2
Gerrit-Owner: Idwer Vollering
vidwer@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Idwer Vollering
vidwer@gmail.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Sun, 09 May 2021 19:50:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment