Attention is currently required from: Patrick Rudolph. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49303 )
Change subject: cpu/x86/mpinit: Serialize microcode updates for HT threads ......................................................................
Patch Set 1:
(8 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/49303/comment/e9dac428_4739a674 PS1, Line 10: affect affect*ed*
https://review.coreboot.org/c/coreboot/+/49303/comment/21358128_a0453571 PS1, Line 17: code co*r*e
https://review.coreboot.org/c/coreboot/+/49303/comment/a68f145d_70bf7422 PS1, Line 18: determining to determine
https://review.coreboot.org/c/coreboot/+/49303/comment/8d10fdfa_0c55b66c PS1, Line 19: initializing and picking the right semaphore out of CONFIG_MAX_CPUS / 2, : only every use a global spinlock. I'm afraid I don't understand what this part tries to say.
https://review.coreboot.org/c/coreboot/+/49303/comment/14968de6_296ef6ae PS1, Line 23: neglectable negligible
File src/cpu/intel/model_1067x/mp_init.c:
https://review.coreboot.org/c/coreboot/+/49303/comment/9c7a082e_9b35945f PS1, Line 36: *parallel = !intel_ht_supported(); Hmmm, but 1067x doesn't support HT. I don't mind doing this on all platforms for consistency, though.
File src/cpu/x86/sipi_vector.S:
https://review.coreboot.org/c/coreboot/+/49303/comment/ce1b7dd3_51609522 PS1, Line 106: need needs
https://review.coreboot.org/c/coreboot/+/49303/comment/52b8a0ca_73054db0 PS1, Line 133: */ The comments on the commit message also apply here.