Attention is currently required from: Praveen HP, Mario Scheithauer, Lean Sheng Tan.
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63775 )
Change subject: soc/intel/ehl: Remove PSE init 'magic code'
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
Patchset:
PS1:
I wouldn't be too fast here.
There are chances that the blob released by Intel does rely on this settings and that the released code simply does not. This would break the blob use-case then.
I would wait a bit until we have gathered more experience with the open source code for the PSE.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63775
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5cfacac62cae0a234e4c4927454311454ab01bdd
Gerrit-Change-Number: 63775
Gerrit-PatchSet: 1
Gerrit-Owner: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Reviewer: Praveen HP
praveen.hodagatta.pranesh@intel.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Praveen HP
praveen.hodagatta.pranesh@intel.com
Gerrit-Attention: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Comment-Date: Fri, 22 Apr 2022 10:52:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment