Change in coreboot[master]: cpu/amd/agesa/family14/model_14_init.c: create correct MTRR solution

[Arthur Heymans (Code Review)]

Attention is currently required from: Michał Żygowski, Michał Kopeć.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52781 )

Change subject: cpu/amd/agesa/family14/model_14_init.c: create correct MTRR solution
......................................................................

Patch Set 13:

(1 comment)

File src/cpu/amd/agesa/family14/model_14_init.c:

https://review.coreboot.org/c/coreboot/+/52781/comment/d37dd14e_63e7f0b4 
PS7, Line 24: if (acpi_is_wakeup_s3()) {
            : 		restore_mtrr();
> It looks like the MTRRs are backed up in `BS_POST_DEVICE` (`amd_bs_post_device`), after they're initialized, so the same solution should be restored here, or am I missing something?

I'm under the impression that save/restore_mtrr was only done because only AGESA was setting up MTRRs and itdoes not do that on S3 resume.

If you do MTRR natively in coreboot you should drop that code to save and restore AGESA MTRR setup and always call x86_setup_mtrrs_with_detect.