Attention is currently required from: Paz Zcharya, Subrata Banik, Terry Chen, Tim Wawrzynczak, Nick Vaccaro, Franklin Lin, Rajat Jain.
Tarun Tuli has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68868 )
Change subject: mb/google/brya: Update Crota's ELAN touchscreen delay to 150 ms
......................................................................
Patch Set 6: Code-Review+2
(1 comment)
File src/mainboard/google/brya/variants/crota/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/68868/comment/2060cc16_ff750705
PS6, Line 225: 150
Oh I think Subrata is saying why do we need 150ms on Crota? If so, yes I think I agree with Paz's […]
I think we really need to ensure we are meeting the timings and not hope we inherently get enough.
The spec specifies two timings, one before we can send for a i2c ack (20ms) and one for i2c hid/enumeration to start (150ms). We'd want to see which is happening first and how long that is after we de-assert reset.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68868
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I17e1f7d419637f6dff4049484ce1836ad98017ea
Gerrit-Change-Number: 68868
Gerrit-PatchSet: 6
Gerrit-Owner: Paz Zcharya
pazz@google.com
Gerrit-Reviewer: Eran Mitrani
mitrani@google.com
Gerrit-Reviewer: Franklin Lin
franklin_lin@wistron.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: Terry Chen
terry_chen@wistron.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Rajat Jain
rajatja@google.com
Gerrit-Attention: Paz Zcharya
pazz@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Terry Chen
terry_chen@wistron.corp-partner.google.com
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Franklin Lin
franklin_lin@wistron.corp-partner.google.com
Gerrit-Attention: Rajat Jain
rajatja@google.com
Gerrit-Comment-Date: Wed, 26 Oct 2022 17:30:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Paz Zcharya
pazz@google.com
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Rajat Jain
rajatja@google.com
Gerrit-MessageType: comment