Attention is currently required from: Evan Green.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64002 )
Change subject: soc/intel: Return ACPI_S4 as previous sleep state
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/64002/comment/dfd9ff5e_6cb64ebf
PS1, Line 8:
Mention the problem, that suspend to disk currently does not(?) work?
https://review.coreboot.org/c/coreboot/+/64002/comment/c037d647_be467b3b
PS1, Line 10: acpi_sleep_from_pm1()
Nit: Fits on the line above.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/64002
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3fb3dc428a749db80293e51a04a2096514a7b689
Gerrit-Change-Number: 64002
Gerrit-PatchSet: 1
Gerrit-Owner: Evan Green
evgreen@chromium.org
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Evan Green
evgreen@chromium.org
Gerrit-Comment-Date: Tue, 03 May 2022 07:24:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment