Change in coreboot[master]: mb/google/volteer: Define stop_gpio for goodix touch screen - coreboot-gerrit

12 Aug 2020


      Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44356 )
Change subject: mb/google/volteer: Define stop_gpio for goodix touch screen
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/44356/1/src/mainboard/google/voltee... 
File src/mainboard/google/volteer/variants/volteer/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/44356/1/src/mainboard/google/voltee... 
PS1, Line 93: 120
...
no, i haven't tried to optimize these values. i'm not even sure […]
Yeah, we had some issues with the goodix timing params in hatch... I don't know if it's the same panel or not.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/44356
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3ead9cf79812d08c4917be4585ed273050465a9b
Gerrit-Change-Number: 44356
Gerrit-PatchSet: 2
Gerrit-Owner: Caveh Jalali caveh@chromium.org
Gerrit-Reviewer: Mice Lin mice_lin@wistron.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 12 Aug 2020 17:14:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Caveh Jalali caveh@chromium.org
Comment-In-Reply-To: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-MessageType: comment