Attention is currently required from: Alicja Michalska, Christian Walter, Eric Lai, Felix Held, Johnny Lin, Jonathan Zhang, Patrick Rudolph, Tim Chu, yuchi.chen@intel.com.
Shuo Liu has posted comments on this change by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/85170?usp=email )
Change subject: soc/intel/xeon_sp/skx: Configure IOAPICs
......................................................................
Patch Set 5:
(3 comments)
File src/soc/intel/xeon_sp/skx/ioapic.c:
https://review.coreboot.org/c/coreboot/+/85170/comment/af8bbfa1_4670af71?usp... :
PS4, Line 47: }
that is correct.
Is there special reason that in SKX, the linear GSI assignment is not usable? I guess is to match the static _PRT reporting results?
https://review.coreboot.org/c/coreboot/+/85170/comment/9df52943_033dbd73?usp... :
PS4, Line 49: i
#include <arch/ioapic. […]
So, do we need to rebase this patch on https://review.coreboot.org/c/coreboot/+/85226/?
https://review.coreboot.org/c/coreboot/+/85170/comment/0041f208_04c2bad1?usp... :
PS4, Line 61: .enable_resources = pci_dev_enable_resources,
it's a PCI endpoint device
Are 0x2036/0x2026 PCI root port devices?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85170?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3bd69e6293b1994a4b3a49361fa7eb45cc0a3a5f
Gerrit-Change-Number: 85170
Gerrit-PatchSet: 5
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Alicja Michalska
ahplka19@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Shuo Liu
shuo.liu@intel.com
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: yuchi.chen@intel.com
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: yuchi.chen@intel.com
Gerrit-Attention: Alicja Michalska
ahplka19@gmail.com
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Comment-Date: Tue, 26 Nov 2024 03:07:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Comment-In-Reply-To: Shuo Liu
shuo.liu@intel.com