Change in coreboot[master]: soc/qualcomm/common: Make clock_configure() check for exact matches
Attention is currently required from: Taniya Das, Paul Menzel, Julius Werner. Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63289 )
Change subject: soc/qualcomm/common: Make clock_configure() check for exact matches ......................................................................
Patch Set 9:
(4 comments)
File src/soc/qualcomm/common/clock.c:
https://review.coreboot.org/c/coreboot/+/63289/comment/93bf5dbd_305a56ca PS8, Line 103: if (hz != clk_cfg[idx].hz)
Wait! Wait wait wait... sorry, should have seen this earlier. […]
Done
File src/soc/qualcomm/sc7280/clock.c:
https://review.coreboot.org/c/coreboot/+/63289/comment/9c3f5f26_ceceb1dc PS7, Line 412: mdss_clk_cfg.hz = mdss_mdp_cfg[idx].hz;
This isn't enough: for the (clk_type != MDSS_CLK_MDP) clocks, we never get here. […]
Done
https://review.coreboot.org/c/coreboot/+/63289/comment/6d023640_0de87e26 PS7, Line 412: mdss_clk_cfg.hz = mdss_mdp_cfg[idx].hz;
Indentation?
I'm not sure what you're referring to? Can you be more specific?
File src/soc/qualcomm/sc7280/clock.c:
https://review.coreboot.org/c/coreboot/+/63289/comment/10fe1dac_06eb62d6 PS8, Line 418: mdss_clk_cfg.hz = mdss_mdp_cfg[idx].hz;
Well, now you're again risking that `mdss_clk_cfg.hz` and `hz` don't match, though. […]
Ok, I see. We were still passing in hz to clock_configure(). How about we pass in mdss_clk_cfg.hz instead of modifying the parameter?
-
Shelley Chen (Code Review)