New patch to review for coreboot: c14ad07 libpayload: provide missing cbfs symbol

[Isaac Christensen]

Isaac Christensen ([e-mail]) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6411

-gerrit

commit c14ad073f8afb85008178802046d31d3f8cda95e
Author: Aaron Durbin <[e-mail]>
Date:   Tue May 28 09:25:32 2013 -0500

    libpayload: provide missing cbfs symbol
    
    The generic cbfs code relies on the libpayload_init_default_cbfs_media
    symbol. However, none was provided for ARM. Provide an empty
    implementation that returns an error as there is no generic way
    to locate the default cbfs media.
    
    Old-Change-Id: Ie0d06fbe6fc790c9d92434cd2d60922908acdc69
    Signed-off-by: Aaron Durbin <[e-mail]>
    Reviewed-on: https://gerrit.chromium.org/gerrit/56805
    Reviewed-by: Duncan Laurie <[e-mail]>
    (cherry picked from commit d3410c28ef9f37b832e2fa2d18351dda332bc9f7)
    
    libpayload: place dummy_media.c in correct object list
    
    The commit introducing dummy_media.c was placed in the
    libc object list. This wasn't correct. It should be in the
    libcbfs object list as well as guarded by CONFIG_CBFS.
    
    Old-Change-Id: Iace43fff8f85f60ecac5e6eb8350cd1f3ee9d35e
    Signed-off-by: Aaron Durbin <[e-mail]>
    Reviewed-on: https://gerrit.chromium.org/gerrit/56925
    (cherry picked from commit 7937c7c5e95a934593bc0cedd5f4496b4770c303)
    
    Squashed two related commits.
    
    Change-Id: I84cd132b44cc2ea5b29acf109a3562baaeede9c6
    Signed-off-by: Isaac Christensen <[e-mail]>
---
 payloads/libpayload/arch/armv7/Makefile.inc  |  1 +
 payloads/libpayload/arch/armv7/dummy_media.c | 42 ++++++++++++++++++++++++++++
 2 files changed, 43 insertions(+)

diff --git a/payloads/libpayload/arch/armv7/Makefile.inc b/payloads/libpayload/arch/armv7/Makefile.inc
index 2c7c9e9..a27fdd4 100644
--- a/payloads/libpayload/arch/armv7/Makefile.inc
+++ b/payloads/libpayload/arch/armv7/Makefile.inc
@@ -36,3 +36,4 @@ libc-y += virtual.c
 libc-y += memcpy.S memset.S
 libc-y += exception_asm.S exception.c
 libc-y += cache.c
+libcbfs-$(CONFIG_CBFS) += dummy_media.c
diff --git a/payloads/libpayload/arch/armv7/dummy_media.c b/payloads/libpayload/arch/armv7/dummy_media.c
new file mode 100644
index 0000000..7926976
--- /dev/null
+++ b/payloads/libpayload/arch/armv7/dummy_media.c
@@ -0,0 +1,42 @@
+/*
+ * This file is part of the libpayload project.
+ *
+ * Copyright (C) 2013 Google, Inc.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ *    notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ *    notice, this list of conditions and the following disclaimer in the
+ *    documentation and/or other materials provided with the distribution.
+ * 3. The name of the author may not be used to endorse or promote products
+ *    derived from this software without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ``AS IS'' AND
+ * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
+ * ARE DISCLAIMED.  IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE
+ * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
+ * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
+ * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
+ * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
+ * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
+ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
+ * SUCH DAMAGE.
+ */
+#define LIBPAYLOAD
+
+#include <cbfs.h>
+#include <string.h>
+
+/* The generic cbfs code relies on the libpayload_init_default_cbfs_media
+ * symbol. Therefore, provide an implementation that just throws an error. */
+
+int libpayload_init_default_cbfs_media(struct cbfs_media *media);
+
+int libpayload_init_default_cbfs_media(struct cbfs_media *media)
+{
+	return -1;
+}